This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add a unit-test to verify that root surface transformation affects platform view coordinates. #12783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tform view coordinates. See b/141980393 for details. In the issue, the embedder (assumed to render Flutter contents of size 800 x 600 [1]) is meant to be displayed on its side. To achieve this, it specifies a root surface transformation that translates the surface by its width (or height when it held in the correct viewing position) and then rotates it counter-clockwise by 90 degrees. This test verifies that the Flutter Engine accounts for those transformations in the custom compositor platform view coodinates. [1] The actual size is something different. 800x600 is for illustrative purposes.
jason-simmons
approved these changes
Oct 4, 2019
|
The issue has been addressed. Landing. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2019
…fect platform view coordinates. (flutter/engine#12783)
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 8, 2019
git@github.com:flutter/engine.git/compare/5b3182294f63...c635d70 git log 5b31822..c635d70 --no-merges --oneline 2019-10-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 902cf1e12a74..1494a7f1ec03 (10 commits) (flutter/engine#13000) 2019-10-08 liyuqian@google.com SkSL precompile (flutter/engine#12412) 2019-10-08 chinmaygarde@google.com Compile sanitizer suppressions list and file bugs as necessary. (flutter/engine#12991) 2019-10-08 chinmaygarde@google.com Add a unit-test to verify that root surface transformation affect platform view coordinates. (flutter/engine#12783) 2019-10-08 katelovett@google.com Re-land Adding Link Semantics (flutter/engine#12972) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
git@github.com:flutter/engine.git/compare/5b3182294f63...c635d70 git log 5b31822..c635d70 --no-merges --oneline 2019-10-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 902cf1e12a74..1494a7f1ec03 (10 commits) (flutter/engine#13000) 2019-10-08 liyuqian@google.com SkSL precompile (flutter/engine#12412) 2019-10-08 chinmaygarde@google.com Compile sanitizer suppressions list and file bugs as necessary. (flutter/engine#12991) 2019-10-08 chinmaygarde@google.com Add a unit-test to verify that root surface transformation affect platform view coordinates. (flutter/engine#12783) 2019-10-08 katelovett@google.com Re-land Adding Link Semantics (flutter/engine#12972) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See b/141980393 for details.
In the issue, the embedder (assumed to render Flutter contents of size 800 x 600 [1]) is meant to be displayed on its side. To achieve this, it specifies a root surface transformation that translates the surface by its width (or height when it held in the correct viewing position) and then rotates it counter-clockwise by 90 degrees. This test verifies that the Flutter Engine accounts for those transformations in the custom compositor platform view coodinates.
[1] The actual size is something different. 800x600 is for illustrative purposes.