Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove ability to override mac_sdk_path in flutter/tools/gn #11013

Merged
merged 1 commit into from
Aug 15, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions tools/gn
Original file line number Diff line number Diff line change
Expand Up @@ -259,11 +259,8 @@ def to_gn_args(args):
gn_args['full_dart_sdk'] = args.full_dart_sdk

if sys.platform == 'darwin':
gn_args['mac_sdk_path'] = args.mac_sdk_path
if args.build_glfw_shell:
gn_args['build_glfw_shell'] = True
if gn_args['mac_sdk_path'] == '':
gn_args['mac_sdk_path'] = os.getenv('FLUTTER_MAC_SDK_PATH', '')

return gn_args

Expand Down Expand Up @@ -326,10 +323,6 @@ def parse_args(args):
help='include trained dart2js and dartdevc snapshots. Enable only on steps that create an SDK')
parser.add_argument('--no-full-dart-sdk', dest='full_dart_sdk', action='store_false')

parser.add_argument('--mac-sdk-path', default='', type=str,
help='On the mac, the SDK is inferred from the Xcode location unless this flag is specified. ' +
' Setting the FLUTTER_MAC_SDK_PATH environment variable achieves the same effect.')

parser.add_argument('--ide', default='', type=str,
help='The IDE files to generate using GN. Use `gn gen help` and look for the --ide flag to' +
' see supported IDEs. If this flag is not specified, a platform specific default is selected.')
Expand Down