iOS external texture causes OOM

[WATER1350]

IOSExternalTextureGL use fml::CFRef to release an old CVPixelBufferRef and reference a new CVPixelBufferRef. However, if the new CVPixelBufferRef has same memory address as the old, the old one will not be released though they contain different data. This bug causes serious memory leak when using video plugin supported by external texture. @chinmaygarde Would you please take a look at this?

[cbracken]

@WATER1350 if this is safe to do, then we should really remove the buffer_ref_ private field on the class and just use it as a local.

It looks like OnGrContextCreated also calls CreateTextureFromPixelBuffer, which relies on buffer_ref_, applying this change would change the behaviour if that were called with a non-null buffer_ref_. @chinmaygarde can you provide some insight here?

[WATER1350]

Is there any reason for us to retain the pixelBuffer in buffer_ref_ private field on the class? @cbracken

[cbracken]

Thanks for your contribution! Closing, since I believe this has been superseded by #10326.

[WATER1350]

Thanks for your contribution! Closing, since I believe this has been superseded by #10326.

They're not related