Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 496ef6a9c277
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c90fadf45d44
Choose a head ref
  • 6 commits
  • 35 files changed
  • 3 contributors

Commits on Sep 12, 2023

  1. [iOS] move arm64 builds to arm machines (#45721) 

    Some builds in ci can happen on arm machines, see https://github.com/flutter/engine/pull/45664/files#r1322197862

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    Chris Yang authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    54eac35 View commit details
    Browse the repository at this point in the history

  2. [ios] Fix testDeallocated failing locally. (#45663) 

    Moving the code block to autorelease pool to ensure the FlutterEngine is released in the test.

Fixes: flutter/flutter#134388

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    Chris Yang authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    2c53043 View commit details
    Browse the repository at this point in the history

  3. Fix JS interop signatures to use only JS types. (#45668) 

    This prepares for some upcoming changes to dart2js which will be more strict about what types can be used in a JS interop declaration.
    @eyebrowsoffire
    eyebrowsoffire authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    14a858c View commit details
    Browse the repository at this point in the history

  4. Roll Skia from a4f8f5177c8b to 211d63b1e1f5 (2 revisions) (#45724) 

    https://skia.googlesource.com/skia.git/+log/a4f8f5177c8b..211d63b1e1f5

2023-09-12 brianosman@google.com Add basic support for kRGBA_10x6_SkColorType
2023-09-12 michaelludwig@google.com Use over-sampling to avoid branches in 2D blur effect

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    968ea4f View commit details
    Browse the repository at this point in the history

  5. Reland "Build iOS unittest target in unopt builds" (#44356)"" (#45346)… 

    …" (#45519)

Reland #44821

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    Chris Yang authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    eab8b71 View commit details
    Browse the repository at this point in the history

  6. Manual roll Dart SDK from 43d4b1373788 to 1ee7ef8bbc65 (6 revisions) (#… 

    …45726)

Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/43d4b1373788..1ee7ef8bbc65

2023-09-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-140.0.dev
2023-09-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-139.0.dev
2023-09-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-138.0.dev
2023-09-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-137.0.dev
2023-09-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-136.0.dev
2023-09-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-135.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c90fadf View commit details
    Browse the repository at this point in the history
Loading