This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Revert "Build iOS unittest target in unopt builds" #44356
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9c17c35.
hellohuanlin
approved these changes
Aug 3, 2023
Landing on red to fix the tree. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 4, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 4, 2023
…131905) flutter/engine@098ec48...ca8d852 2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 0a376550f218 to a3d2051afa4a (4 revisions) (flutter/engine#44362) 2023-08-03 ychris@google.com Revert "Build iOS unittest target in unopt builds" (flutter/engine#44356) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
Reverts flutter#44301 ``` Traceback (most recent call last): File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 1286, in <module> sys.exit(main()) File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 1269, in main run_objc_tests(args.ios_variant, args.objc_filter) File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 721, in run_objc_tests ensure_ios_tests_are_built(ios_out_dir) File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 625, in ensure_ios_tests_are_built assert flutter_dylib_time <= ios_test_lib_time, final_message AssertionError: /Volumes/Work/s/w/ir/cache/builder/src/out/ios_debug_sim_arm64_extension_safe/libios_test_flutter.dylib is older than /Volumes/Work/s/w/ir/cache/builder/src/out/ios_debug_sim_arm64_extension_safe/libFlutter.dylib. Please run the following commands: gn --ios --unoptimized --runtime-mode=debug --no-lto --simulator ninja -C /Volumes/Work/s/w/ir/cache/builder/src/out/ios_debug_sim_arm64_extension_safe ios_test_flutter ``` It failed we in run_test.py we check if the ios_test is built after the framework, which is not true anymore after moving the test inside the build target.
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
Relands #44301 The original PR was reverted in #44356 The `assert flutter_dylib_time <= ios_test_lib_time, final_message` check is reverted in 70dd9e4, so we are safe to land this again. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
zanderso
added a commit
that referenced
this pull request
Aug 31, 2023
zanderso
added a commit
that referenced
this pull request
Aug 31, 2023
cyanglaz
pushed a commit
to cyanglaz/engine
that referenced
this pull request
Sep 6, 2023
…lutter#44356)"" (flutter#45346)" This reverts commit ca513c9.
cyanglaz
pushed a commit
to cyanglaz/engine
that referenced
this pull request
Sep 7, 2023
…lutter#44356)"" (flutter#45346)" This reverts commit ca513c9. fix 1 fix fix temp ci change fix name space fix fix fix format
cyanglaz
pushed a commit
to cyanglaz/engine
that referenced
this pull request
Sep 8, 2023
…lutter#44356)"" (flutter#45346)" This reverts commit ca513c9. fix 1 fix fix temp ci change fix name space fix fix fix format
cyanglaz
pushed a commit
to cyanglaz/engine
that referenced
this pull request
Sep 8, 2023
…lutter#44356)"" (flutter#45346)" This reverts commit ca513c9. fix 1 fix fix temp ci change fix name space fix fix fix format revert fix draft fix unittest fix fromat eof line
auto-submit bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
…" (#45519) Reland #44821 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
platform-ios
warning: land on red to fix tree breakage
Override tree-status signal (land even with closed tree), combine with the autosubmit label.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #44301
It failed we in run_test.py we check if the ios_test is built after the framework, which is not true anymore after moving the test inside the build target.