Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 098ec489585e
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ca8d852eddfc
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Aug 3, 2023

  1. Revert "Build iOS unittest target in unopt builds" (#44356)

    Reverts #44301
    
    ```
    Traceback (most recent call last):
      File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 1286, in <module>
        sys.exit(main())
      File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 1269, in main
        run_objc_tests(args.ios_variant, args.objc_filter)
      File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 721, in run_objc_tests
        ensure_ios_tests_are_built(ios_out_dir)
      File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 625, in ensure_ios_tests_are_built
        assert flutter_dylib_time <= ios_test_lib_time, final_message
    AssertionError: /Volumes/Work/s/w/ir/cache/builder/src/out/ios_debug_sim_arm64_extension_safe/libios_test_flutter.dylib is older than /Volumes/Work/s/w/ir/cache/builder/src/out/ios_debug_sim_arm64_extension_safe/libFlutter.dylib. Please run the following commands: 
    gn --ios --unoptimized --runtime-mode=debug --no-lto --simulator
    ninja -C /Volumes/Work/s/w/ir/cache/builder/src/out/ios_debug_sim_arm64_extension_safe ios_test_flutter
    ```
    
    It failed we in run_test.py we check if the ios_test is built after the framework, which is not true anymore after moving the test inside the build target.
    Chris Yang authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    f35213f View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Roll Skia from 0a376550f218 to a3d2051afa4a (4 revisions) (#44362)

    https://skia.googlesource.com/skia.git/+log/0a376550f218..a3d2051afa4a
    
    2023-08-03 johnstiles@google.com Add basic WGSL support for derivatives.
    2023-08-03 armansito@google.com [graphite][dawn] Suppress compiler warning on string format type
    2023-08-03 robertphillips@google.com Cosmetic changes pulled out of Protected content CL
    2023-08-03 jvanverth@google.com [graphite] Remove GRAPHITE_TEST_UTILS from Recording
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Aug 4, 2023
    Configuration menu
    Copy the full SHA
    ca8d852 View commit details
    Browse the repository at this point in the history
Loading