Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 081fbab5f277
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c31cfc517274
Choose a head ref
  • 5 commits
  • 20 files changed
  • 5 contributors

Commits on Jul 13, 2023

  1. Improve Stencil Playground test (#43641) 

    - Add UI to select front and back face comparision functions.
- Fix back face.
    @johnmccutchan
    johnmccutchan authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    5845102 View commit details
    Browse the repository at this point in the history

  2. [web] TextField a11y focus should call didGain/didLose a11y focus act… 

    …ion (#43279)

fixes flutter/flutter#128709

requires flutter/flutter#129652

The issue is that when textfield focus in framework and web engine a11y are out of sync, the framework keep sending update with textfield focus = true and causes web engine to keep refocusing the textfield.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @chunhtai
    chunhtai authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    d3adaed View commit details
    Browse the repository at this point in the history

  3. Revert "Add a flag to ParagraphBuilder for rounding hack migration" (… 

    …#43642)

Reverts #43118

The incorrect default value (`true` instead of  `false`) was used in the PR and that caused internal test failures. I'll add a test before trying to reland.
    @LongCatIsLooong
    LongCatIsLooong authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    49a0405 View commit details
    Browse the repository at this point in the history

  4. Add logs to debug VM Service Publication (#43616) 

    Adding logs to help debug why VM Service is being published when it shouldn't (flutter/flutter#129987 and flutter/flutter#129836).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @vashworth
    vashworth authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    7a78b3d View commit details
    Browse the repository at this point in the history

  5. [Impeller] Switch back to using explicit flush for device buffers. (#… 

    …43644)

Not all devices support the host_coherent + host_visible + device_local combo (though most do). I believe this change was associated with a slight regression in performance, so back it out and go back to flush to see if that improves things.

https://flutter-flutter-perf.skia.org/e/?begin=1687535096&end=1689267073&queries=device_type%3DSM-G973U1%26test%3Dnew_gallery_impeller__transition_perf&requestType=0&selected=commit%3D35596%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DSM-G973U1%252Cdevice_version%253Dnone%252Chost_type%253Dlinux%252Csub_result%253D99th_percentile_frame_rasterizer_time_millis%252Ctest%253Dnew_gallery_impeller__transition_perf%252C

Specifically:

![image](https://github.com/flutter/engine/assets/8975114/fedabc18-9091-45c0-b7b3-ee9945c2239c)
    @jonahwilliams
    jonahwilliams authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    c31cfc5 View commit details
    Browse the repository at this point in the history
Loading