Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 7a78b3d

Browse files
authored
Add logs to debug VM Service Publication (#43616)
Adding logs to help debug why VM Service is being published when it shouldn't (flutter/flutter#129987 and flutter/flutter#129836). [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
1 parent 49a0405 commit 7a78b3d

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

shell/platform/darwin/ios/framework/Source/FlutterDartVMServicePublisher.mm

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,8 @@ - (void)stopService {
8080
}
8181

8282
- (void)publishServiceProtocolPort:(NSURL*)url {
83+
// TODO(vashworth): Remove once done debugging https://github.com/flutter/flutter/issues/129836
84+
FML_LOG(INFO) << "Publish Service Protocol Port";
8385
DNSServiceFlags flags = kDNSServiceFlagsDefault;
8486
#if TARGET_IPHONE_SIMULATOR
8587
// Simulator needs to use local loopback explicitly to work.

shell/platform/darwin/ios/framework/Source/FlutterEngine.mm

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -871,6 +871,8 @@ - (BOOL)createShell:(NSString*)entrypoint
871871
FML_LOG(ERROR) << "Could not start a shell FlutterEngine with entrypoint: "
872872
<< entrypoint.UTF8String;
873873
} else {
874+
// TODO(vashworth): Remove once done debugging https://github.com/flutter/flutter/issues/129836
875+
FML_LOG(INFO) << "Enabled VM Service Publication: " << settings.enable_vm_service_publication;
874876
[self setupShell:std::move(shell)
875877
withVMServicePublication:settings.enable_vm_service_publication];
876878
if ([FlutterEngine isProfilerEnabled]) {

0 commit comments

Comments
 (0)