Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit f339103

Browse files
chinmaygardechinmaygarde
authored
[Impeller] Remove work queues. (#40429)
[Impeller] Remove work queues.
1 parent 4927fad commit f339103

File tree

17 files changed

+0
-258
lines changed

17 files changed

+0
-258
lines changed

‎ci/licenses_golden/licenses_flutter

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1040,8 +1040,6 @@ ORIGIN: ../../../flutter/impeller/base/backend_cast.h + ../../../flutter/LICENSE
10401040
ORIGIN: ../../../flutter/impeller/base/comparable.cc + ../../../flutter/LICENSE
10411041
ORIGIN: ../../../flutter/impeller/base/comparable.h + ../../../flutter/LICENSE
10421042
ORIGIN: ../../../flutter/impeller/base/config.h + ../../../flutter/LICENSE
1043-
ORIGIN: ../../../flutter/impeller/base/platform/darwin/work_queue_darwin.cc + ../../../flutter/LICENSE
1044-
ORIGIN: ../../../flutter/impeller/base/platform/darwin/work_queue_darwin.h + ../../../flutter/LICENSE
10451043
ORIGIN: ../../../flutter/impeller/base/promise.cc + ../../../flutter/LICENSE
10461044
ORIGIN: ../../../flutter/impeller/base/promise.h + ../../../flutter/LICENSE
10471045
ORIGIN: ../../../flutter/impeller/base/strings.cc + ../../../flutter/LICENSE
@@ -1055,10 +1053,6 @@ ORIGIN: ../../../flutter/impeller/base/validation.cc + ../../../flutter/LICENSE
10551053
ORIGIN: ../../../flutter/impeller/base/validation.h + ../../../flutter/LICENSE
10561054
ORIGIN: ../../../flutter/impeller/base/version.cc + ../../../flutter/LICENSE
10571055
ORIGIN: ../../../flutter/impeller/base/version.h + ../../../flutter/LICENSE
1058-
ORIGIN: ../../../flutter/impeller/base/work_queue.cc + ../../../flutter/LICENSE
1059-
ORIGIN: ../../../flutter/impeller/base/work_queue.h + ../../../flutter/LICENSE
1060-
ORIGIN: ../../../flutter/impeller/base/work_queue_common.cc + ../../../flutter/LICENSE
1061-
ORIGIN: ../../../flutter/impeller/base/work_queue_common.h + ../../../flutter/LICENSE
10621056
ORIGIN: ../../../flutter/impeller/blobcat/blob.fbs + ../../../flutter/LICENSE
10631057
ORIGIN: ../../../flutter/impeller/blobcat/blob_library.cc + ../../../flutter/LICENSE
10641058
ORIGIN: ../../../flutter/impeller/blobcat/blob_library.h + ../../../flutter/LICENSE
@@ -3577,8 +3571,6 @@ FILE: ../../../flutter/impeller/base/backend_cast.h
35773571
FILE: ../../../flutter/impeller/base/comparable.cc
35783572
FILE: ../../../flutter/impeller/base/comparable.h
35793573
FILE: ../../../flutter/impeller/base/config.h
3580-
FILE: ../../../flutter/impeller/base/platform/darwin/work_queue_darwin.cc
3581-
FILE: ../../../flutter/impeller/base/platform/darwin/work_queue_darwin.h
35823574
FILE: ../../../flutter/impeller/base/promise.cc
35833575
FILE: ../../../flutter/impeller/base/promise.h
35843576
FILE: ../../../flutter/impeller/base/strings.cc
@@ -3592,10 +3584,6 @@ FILE: ../../../flutter/impeller/base/validation.cc
35923584
FILE: ../../../flutter/impeller/base/validation.h
35933585
FILE: ../../../flutter/impeller/base/version.cc
35943586
FILE: ../../../flutter/impeller/base/version.h
3595-
FILE: ../../../flutter/impeller/base/work_queue.cc
3596-
FILE: ../../../flutter/impeller/base/work_queue.h
3597-
FILE: ../../../flutter/impeller/base/work_queue_common.cc
3598-
FILE: ../../../flutter/impeller/base/work_queue_common.h
35993587
FILE: ../../../flutter/impeller/blobcat/blob.fbs
36003588
FILE: ../../../flutter/impeller/blobcat/blob_library.cc
36013589
FILE: ../../../flutter/impeller/blobcat/blob_library.h

‎impeller/base/BUILD.gn

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -25,19 +25,8 @@ impeller_component("base") {
2525
"validation.h",
2626
"version.cc",
2727
"version.h",
28-
"work_queue.cc",
29-
"work_queue.h",
30-
"work_queue_common.cc",
31-
"work_queue_common.h",
3228
]
3329

34-
if (is_ios || is_mac) {
35-
sources += [
36-
"platform/darwin/work_queue_darwin.cc",
37-
"platform/darwin/work_queue_darwin.h",
38-
]
39-
}
40-
4130
deps = [ "//flutter/fml" ]
4231
}
4332

‎impeller/base/platform/darwin/work_queue_darwin.cc

Lines changed: 0 additions & 38 deletions
This file was deleted.

‎impeller/base/platform/darwin/work_queue_darwin.h

Lines changed: 0 additions & 36 deletions
This file was deleted.

‎impeller/base/work_queue.cc

Lines changed: 0 additions & 13 deletions
This file was deleted.

‎impeller/base/work_queue.h

Lines changed: 0 additions & 27 deletions
This file was deleted.

‎impeller/base/work_queue_common.cc

Lines changed: 0 additions & 25 deletions
This file was deleted.

‎impeller/base/work_queue_common.h

Lines changed: 0 additions & 33 deletions
This file was deleted.

‎impeller/renderer/backend/gles/context_gles.cc

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
#include "impeller/base/config.h"
88
#include "impeller/base/validation.h"
9-
#include "impeller/base/work_queue_common.h"
109
#include "impeller/renderer/device_capabilities.h"
1110

1211
namespace impeller {
@@ -60,15 +59,6 @@ ContextGLES::ContextGLES(std::unique_ptr<ProcTableGLES> gl,
6059
std::shared_ptr<SamplerLibraryGLES>(new SamplerLibraryGLES());
6160
}
6261

63-
// Create the work queue.
64-
{
65-
work_queue_ = WorkQueueCommon::Create();
66-
if (!work_queue_) {
67-
VALIDATION_LOG << "Could not create work queue.";
68-
return;
69-
}
70-
}
71-
7262
// Create the device capabilities.
7363
{
7464
device_capabilities_ =
@@ -140,11 +130,6 @@ std::shared_ptr<CommandBuffer> ContextGLES::CreateCommandBuffer() const {
140130
new CommandBufferGLES(weak_from_this(), reactor_));
141131
}
142132

143-
// |Context|
144-
std::shared_ptr<WorkQueue> ContextGLES::GetWorkQueue() const {
145-
return work_queue_;
146-
}
147-
148133
// |Context|
149134
const IDeviceCapabilities& ContextGLES::GetDeviceCapabilities() const {
150135
return *device_capabilities_;

‎impeller/renderer/backend/gles/context_gles.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ class ContextGLES final : public Context,
3939
std::shared_ptr<ShaderLibraryGLES> shader_library_;
4040
std::shared_ptr<PipelineLibraryGLES> pipeline_library_;
4141
std::shared_ptr<SamplerLibraryGLES> sampler_library_;
42-
std::shared_ptr<WorkQueue> work_queue_;
4342
std::shared_ptr<AllocatorGLES> resource_allocator_;
4443
std::unique_ptr<IDeviceCapabilities> device_capabilities_;
4544
bool is_valid_ = false;
@@ -66,9 +65,6 @@ class ContextGLES final : public Context,
6665
// |Context|
6766
std::shared_ptr<CommandBuffer> CreateCommandBuffer() const override;
6867

69-
// |Context|
70-
std::shared_ptr<WorkQueue> GetWorkQueue() const override;
71-
7268
// |Context|
7369
const IDeviceCapabilities& GetDeviceCapabilities() const override;
7470

‎impeller/renderer/backend/metal/context_mtl.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ class ContextMTL final : public Context,
4444
std::shared_ptr<PipelineLibraryMTL> pipeline_library_;
4545
std::shared_ptr<SamplerLibrary> sampler_library_;
4646
std::shared_ptr<AllocatorMTL> resource_allocator_;
47-
std::shared_ptr<WorkQueue> work_queue_;
4847
std::shared_ptr<GPUTracerMTL> gpu_tracer_;
4948
std::unique_ptr<IDeviceCapabilities> device_capabilities_;
5049
bool is_valid_ = false;
@@ -71,9 +70,6 @@ class ContextMTL final : public Context,
7170
// |Context|
7271
std::shared_ptr<CommandBuffer> CreateCommandBuffer() const override;
7372

74-
// |Context|
75-
std::shared_ptr<WorkQueue> GetWorkQueue() const override;
76-
7773
// |Context|
7874
std::shared_ptr<GPUTracer> GetGPUTracer() const override;
7975

‎impeller/renderer/backend/metal/context_mtl.mm

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#include "flutter/fml/file.h"
1010
#include "flutter/fml/logging.h"
1111
#include "flutter/fml/paths.h"
12-
#include "impeller/base/platform/darwin/work_queue_darwin.h"
1312
#include "impeller/renderer/backend/metal/sampler_library_mtl.h"
1413
#include "impeller/renderer/device_capabilities.h"
1514
#include "impeller/renderer/sampler_descriptor.h"
@@ -74,15 +73,6 @@
7473
}
7574
}
7675

77-
// Setup the work queue.
78-
{
79-
work_queue_ = WorkQueueDarwin::Create();
80-
if (!work_queue_) {
81-
VALIDATION_LOG << "Could not setup the work queue.";
82-
return;
83-
}
84-
}
85-
8676
#if (FLUTTER_RUNTIME_MODE == FLUTTER_RUNTIME_MODE_DEBUG) || \
8777
(FLUTTER_RUNTIME_MODE == FLUTTER_RUNTIME_MODE_PROFILE)
8878
// Setup the gpu tracer.
@@ -257,11 +247,6 @@
257247
return CreateCommandBufferInQueue(command_queue_);
258248
}
259249

260-
// |Context|
261-
std::shared_ptr<WorkQueue> ContextMTL::GetWorkQueue() const {
262-
return work_queue_;
263-
}
264-
265250
std::shared_ptr<GPUTracer> ContextMTL::GetGPUTracer() const {
266251
return gpu_tracer_;
267252
}

‎impeller/renderer/backend/vulkan/context_vk.cc

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
#include "flutter/fml/string_conversion.h"
1616
#include "flutter/fml/trace_event.h"
1717
#include "impeller/base/validation.h"
18-
#include "impeller/base/work_queue_common.h"
1918
#include "impeller/renderer/backend/vulkan/allocator_vk.h"
2019
#include "impeller/renderer/backend/vulkan/capabilities_vk.h"
2120
#include "impeller/renderer/backend/vulkan/command_buffer_vk.h"
@@ -479,13 +478,6 @@ ContextVK::ContextVK(
479478
return;
480479
}
481480

482-
auto work_queue = WorkQueueCommon::Create();
483-
484-
if (!work_queue) {
485-
VALIDATION_LOG << "Could not create workqueue.";
486-
return;
487-
}
488-
489481
//----------------------------------------------------------------------------
490482
/// Setup the command pool.
491483
///
@@ -541,7 +533,6 @@ ContextVK::ContextVK(
541533
shader_library_ = std::move(shader_library);
542534
sampler_library_ = std::move(sampler_library);
543535
pipeline_library_ = std::move(pipeline_library);
544-
work_queue_ = std::move(work_queue);
545536
graphics_queue_ =
546537
device_->getQueue(graphics_queue->family, graphics_queue->index);
547538
compute_queue_ =
@@ -592,11 +583,6 @@ std::shared_ptr<PipelineLibrary> ContextVK::GetPipelineLibrary() const {
592583
return pipeline_library_;
593584
}
594585

595-
// |Context|
596-
std::shared_ptr<WorkQueue> ContextVK::GetWorkQueue() const {
597-
return work_queue_;
598-
}
599-
600586
std::shared_ptr<CommandBuffer> ContextVK::CreateCommandBuffer() const {
601587
return std::shared_ptr<CommandBufferVK>(
602588
new CommandBufferVK(shared_from_this(), //

0 commit comments

Comments
 (0)