Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Remove work queues. #40429

Merged
merged 2 commits into from
Mar 18, 2023
Merged

[Impeller] Remove work queues. #40429

merged 2 commits into from
Mar 18, 2023

Conversation

chinmaygarde
Copy link
Member

No description provided.

@chinmaygarde chinmaygarde requested review from bdero and dnfield March 18, 2023 19:36
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@chinmaygarde
Copy link
Member Author

These were supposed to be the basis of multi-threaded render pass encoding. However, I didn't finish this line of work and the workqueue were causing issues on CI that @dnfield was running into. Backing out the whole thing. Will revert and build again on top of this in the future.

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2023
@auto-submit auto-submit bot merged commit f339103 into flutter:main Mar 18, 2023
@chinmaygarde chinmaygarde deleted the rmwq branch March 18, 2023 23:44
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 19, 2023
@dnfield
Copy link
Contributor

dnfield commented Mar 19, 2023

Nice. I don't think this was the root of the CI issue, but instruments complained about it

@chinmaygarde
Copy link
Member Author

I don't think this was the root of the CI issue...

Is there a list of these issues, I can attempt to tackle these today.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 19, 2023
zanderso pushed a commit to flutter/flutter that referenced this pull request Mar 19, 2023
…122962)

* eded0aeda Roll Fuchsia Linux SDK from cbVcty00KkB3vbCBQ... to PDGxZavi1gOc3IvRW... (flutter/engine#40432)

* 4927fadb0 [Impeller] Prevent passes from reading their own resolve texture on the Vulkan and GL backends (flutter/engine#40418)

* f33910308 [Impeller] Remove work queues. (flutter/engine#40429)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller needs tests
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants