-
Notifications
You must be signed in to change notification settings - Fork 6k
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
These were supposed to be the basis of multi-threaded render pass encoding. However, I didn't finish this line of work and the workqueue were causing issues on CI that @dnfield was running into. Backing out the whole thing. Will revert and build again on top of this in the future. |
Nice. I don't think this was the root of the CI issue, but instruments complained about it |
Is there a list of these issues, I can attempt to tackle these today. |
…122962) * eded0aeda Roll Fuchsia Linux SDK from cbVcty00KkB3vbCBQ... to PDGxZavi1gOc3IvRW... (flutter/engine#40432) * 4927fadb0 [Impeller] Prevent passes from reading their own resolve texture on the Vulkan and GL backends (flutter/engine#40418) * f33910308 [Impeller] Remove work queues. (flutter/engine#40429)
No description provided.