Skip to content

Commit

Permalink
Remove legacy references to Cirrus and suspected dead-code. (#50442)
Browse files Browse the repository at this point in the history
  • Loading branch information
matanlurey authored Feb 10, 2024
1 parent 1478f4e commit b06b3e0
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 61 deletions.
10 changes: 2 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
Flutter Engine
==============
# Flutter Engine

[![Flutter CI Status](https://flutter-dashboard.appspot.com/api/public/build-status-badge?repo=engine)](https://flutter-dashboard.appspot.com/#/build?repo=engine)
[![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/flutter/engine/badge)](https://deps.dev/project/github/flutter%2Fengine)
Expand All @@ -11,7 +10,7 @@ code, is used by developers and organizations around the world, and is free
and open source.

The Flutter Engine is a portable runtime for hosting
[Flutter](https://flutter.dev) applications. It implements Flutter's core
[Flutter](https://flutter.dev) applications. It implements Flutter's core
libraries, including animation and graphics, file and network I/O,
accessibility support, plugin architecture, and a Dart runtime and compile
toolchain. Most developers will interact with Flutter via the [Flutter
Expand All @@ -31,8 +30,3 @@ the [docs.flutter.dev](https://docs.flutter.dev/).
Flutter is a fully open source project, and we welcome contributions.
Information on how to get started can be found at our
[contributor guide](CONTRIBUTING.md).

[Build Status - Cirrus]: https://api.cirrus-ci.com/github/flutter/engine.svg?branch=main

[Build status]: https://cirrus-ci.com/github/flutter/engine

11 changes: 0 additions & 11 deletions lib/web_ui/dart_test_chrome.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,3 @@
platforms:
- chrome
- vm

presets:
cirrus:
override_platforms:
chrome:
settings:
# Required because Cirrus runs us as root.
# https://chromium.googlesource.com/chromium/src/+/master/docs/design/sandbox.md
# https://docs.travis-ci.com/user/chrome#Sandboxing
arguments: --no-sandbox
reporter: expanded
5 changes: 1 addition & 4 deletions lib/web_ui/dev/common.dart
Original file line number Diff line number Diff line change
Expand Up @@ -213,15 +213,12 @@ class DevNull implements StringSink {
void writeln([Object? obj = '']) {}
}

/// Whether the felt command is running on Cirrus CI.
bool get isCirrus => io.Platform.environment['CIRRUS_CI'] == 'true';

/// Whether the felt command is running on LUCI.
bool get isLuci => io.Platform.environment['LUCI_CONTEXT'] != null;

/// Whether the felt command is running on one of the Continuous Integration
/// environements.
bool get isCi => isCirrus || isLuci;
bool get isCi => isLuci;

const String kChrome = 'chrome';
const String kEdge = 'edge';
Expand Down
18 changes: 0 additions & 18 deletions lib/web_ui/dev/environment.dart
Original file line number Diff line number Diff line change
Expand Up @@ -213,22 +213,4 @@ class Environment {
webUiDartToolDir.path,
'test_results',
));

/// Path to the script that clones the Flutter repo.
io.File get cloneFlutterScript => io.File(pathlib.join(
engineToolsDir.path,
'clone_flutter.sh',
));

/// Path to flutter.
///
/// For example, this can be used to run `flutter pub get`.
///
/// Only use [cloneFlutterScript] to clone flutter to the engine build.
io.File get flutterCommand => io.File(pathlib.join(
engineDartToolDir.path,
'flutter',
'bin',
'flutter',
));
}
2 changes: 0 additions & 2 deletions lib/web_ui/dev/test_platform.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1147,5 +1147,3 @@ class _BrowserEnvironment implements Environment {
@override
CancelableOperation<void> displayPause() => _manager._displayPause();
}

bool get isCirrus => Platform.environment['CIRRUS_CI'] == 'true';
18 changes: 0 additions & 18 deletions web_sdk/web_test_utils/lib/environment.dart
Original file line number Diff line number Diff line change
Expand Up @@ -158,22 +158,4 @@ class Environment {
webUiDartToolDir.path,
'ios_screenshots',
));

/// Path to the script that clones the Flutter repo.
io.File get cloneFlutterScript => io.File(pathlib.join(
engineToolsDir.path,
'clone_flutter.sh',
));

/// Path to flutter.
///
/// For example, this can be used to run `flutter pub get`.
///
/// Only use [cloneFlutterScript] to clone flutter to the engine build.
io.File get flutterCommand => io.File(pathlib.join(
engineDartToolDir.path,
'flutter',
'bin',
'flutter',
));
}

0 comments on commit b06b3e0

Please sign in to comment.