Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 30980b6

Browse files
committed
Merge pull request #344 from chinmaygarde/master
Fix release builds on iOS
2 parents c3c5c41 + 9f536ab commit 30980b6

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

build/config/compiler/BUILD.gn

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1113,7 +1113,7 @@ if (is_win) {
11131113
}
11141114
}
11151115

1116-
if (is_mac) {
1116+
if (is_mac || is_ios) {
11171117
if (symbol_level == 2) {
11181118
# Mac dead code stripping requires symbols.
11191119
common_optimize_on_ldflags += [ "-Wl,-dead_strip" ]

sky/engine/bindings/builtin_natives.cc

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,10 @@
3131
#endif
3232

3333
#if __APPLE__
34-
#include <syslog.h>
34+
extern "C" {
35+
// Cannot import the syslog.h header directly because of macro collision
36+
extern void syslog(int, const char *, ...);
37+
}
3538
#endif
3639

3740
namespace blink {
@@ -175,7 +178,7 @@ void Logger_PrintString(Dart_NativeArguments args) {
175178
// message is discoverable when running on an unrooted device.
176179
__android_log_print(ANDROID_LOG_INFO, "sky", "%.*s", length, chars);
177180
#elif __APPLE__
178-
syslog(LOG_INFO, "%.*s", (int)length, chars);
181+
syslog(6 /* Informational */, "%.*s", (int)length, chars);
179182
#endif
180183
}
181184
}

0 commit comments

Comments
 (0)