This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix release builds on iOS #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
lgtm |
chinmaygarde
added a commit
that referenced
this pull request
Jul 29, 2015
Fix release builds on iOS
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
This reverts commit 999d459. The updated explanation did not work as I thought.
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
The function object_isClass is only available starting from macOS 10.10 and iOS 8.0 SDKs. To allow targeting older systems (i.e. if the deployment target is older), add an alternate implementation. The implementation is based on the one used by the Swift runtime: swiftlang/swift@0475307c08 Fixes issue flutter#344.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@eseidelGoogle,@iansf