Skip to content

Commit

Permalink
fixed android unit tests (rotted before CI is running) (#28938)
Browse files Browse the repository at this point in the history
  • Loading branch information
gaaclarke authored Sep 29, 2021
1 parent 223d8f9 commit 2a2e116
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions shell/platform/android/android_shell_holder_unittests.cc
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,12 @@ TEST(AndroidShellHolder, Create) {
Settings settings;
settings.enable_software_rendering = false;
auto jni = std::make_shared<MockPlatformViewAndroidJNI>();
auto holder = std::make_unique<AndroidShellHolder>(
settings, jni, /*is_background_view=*/false);
auto holder = std::make_unique<AndroidShellHolder>(settings, jni);
EXPECT_NE(holder.get(), nullptr);
EXPECT_TRUE(holder->IsValid());
EXPECT_NE(holder->GetPlatformView().get(), nullptr);
auto window =
fml::MakeRefCounted<AndroidNativeWindow>(nullptr, /*is_offscreen=*/true);
auto window = fml::MakeRefCounted<AndroidNativeWindow>(
nullptr, /*is_fake_window=*/true);
holder->GetPlatformView()->NotifyCreated(window);
}
} // namespace testing
Expand Down

0 comments on commit 2a2e116

Please sign in to comment.