Skip to content

Get tests running on travis #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 19, 2018
Merged

Conversation

DanTup
Copy link
Contributor

@DanTup DanTup commented Sep 17, 2018

(This isn't ready yet, I'm just opening a PR for convenient running of it without setting up Travis on my fork :-))

@DanTup DanTup changed the title Get tests running on travis [WIP] Get tests running on travis Sep 18, 2018
@DanTup DanTup requested a review from devoncarew September 18, 2018 09:19
@DanTup
Copy link
Contributor Author

DanTup commented Sep 18, 2018

Ok, I've got the tests running on macOS on Travis (both the integration test and the browser-based tables test). The previous Travis config was just running on Linux (the default if not specified) so this changes to OSX.

On Linux, the tables test now passes (we have to run in --no-sandbox mode) but the integration test fails to connect. I may need to set up a VM or Docker locally to try and repro that here to debug better - I'm not sure how much time we want to spend on setting this up on other platforms (on one hand, it's a web app so hopefully platform doesn't matter much, but on the other hand we've had more issues on Windows than we'd like so covering them all might not be a bad idea).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants