De-dupe isolate logic in service_manager #75
Conversation
| for (IsolateRef ref in isolates) { | ||
| // Populate flutter isolate info. | ||
| if (_flutterIsolate == null) { | ||
| if (_selectedIsolate == null) { |
There was a problem hiding this comment.
We may want a notion of a list of flutter isolates, and a selected flutter isolate, and a separate notion of a list of all isolates, and a selected isolate. Right now we don't have the ability to have a selected isolate which is not a flutter isolate (I had been using a command-line app for testing).
There was a problem hiding this comment.
Would this be a sufficient solution? It would guarantee we always have a selected isolate even if none are flutter isolates.
After for loop:
_selectedIsollate ??= isolates.isEmpty ? null : isolates.first;
If that is not sufficient, it sounds like we probably need to revert the changes in this CL.
There was a problem hiding this comment.
Oh nevermind, I see you added this change to #80.
fix "setState() called after dispose()" in build() method
Previously we had _selectedIsolate and _flutterIsolate. These should be the same thing and we do not need both. Removed _flutterIsolate.