Skip to content

Copy of Flutter utility classes to make it simpler to later convert this code to Hummingbird. #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 26, 2018

Conversation

jacob314
Copy link
Contributor

There are no changes to these files other than stripping out portions of files irrelevant on the web
that failed to compile.
As soon as hummingbird is publicly available, these files will be deleted.

dart:html and convert to hummingbird later.
There are no changes to these files other than stripping out portions of
files irrelevant on the web.
@lambdabaa lambdabaa requested review from lambdabaa and removed request for devoncarew and kenzieschmoll December 26, 2018 17:15
Copy link

@lambdabaa lambdabaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! It could be good to file an issue to do the cleanup bits and reference it from these copied files with TODOs so that we don't forget.

@jacob314
Copy link
Contributor Author

Thanks for a review.
Filed
#69
to remove these files once hummingbird is public.

@jacob314 jacob314 merged commit aa5aecc into flutter:master Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants