Skip to content

remove some generated files from the repo #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2018

Conversation

devoncarew
Copy link
Member

Remove the test/fixtures/flutter_app/build/ directory, and the test/fixtures/flutter_app/ios/Flutter/Flutter.framework/Flutter file. The generated build directory we don't need committed to the repo, and the ios Flutter file is large (66MB), and can be re-generated with flutter create ..

@kenzieschmoll

Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenzieschmoll
Copy link
Member

Will this affect testing at all?

@devoncarew
Copy link
Member Author

No for the build/ directory; and the testing is based on running the flutter-tester device, not the iOS. What this will mean is that a user who wants to run the fixture app locally on an ios device will need to re-provision the flutter framework binary file.

@devoncarew devoncarew merged commit 7a1155e into flutter:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants