fix an issue with debugging the integration tests #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/integration_test.dart
Outdated
|
|
||
| // Remove the DART_VM_OPTIONS env variable from the child process, so the | ||
| // Dart VM doesn't try and open a service protocol port if | ||
| // 'DART_VM_OPTIONS: --enable-vm-service:63990' was pass in. |
kenzieschmoll
approved these changes
Dec 13, 2018
|
(updated to use a newer version of |
…/devtools into make_tests_debuggable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running tests from IntelliJ, it sets the
DART_VM_OPTIONSenv option, which cases the VM to bind to the given port. That lets IntelliJ debug unit tests. Our tests were however spawning child dart processes; these were inheriting the parent's env variables, so the child process was also trying to bind to the same port, and failing.@kenzieschmoll