Improve experience in Internet Explorer + tweak Edge message #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will catch really old browsers like IE.
kenzieschmoll
approved these changes
Apr 16, 2019
packages/devtools/web/main.dart
Outdated
| @@ -14,9 +14,13 @@ void main() { | |||
| final PerfToolFramework framework = PerfToolFramework(); | |||
|
|
|||
| if (!browser.isChrome) { | |||
| final browserName = | |||
| // Edge shows up as IE, so we replace it's name too to avoid confusion. | |||
There was a problem hiding this comment.
Whoops, must be a bug in my keyboard 😄
Thanks!
kenzieschmoll
approved these changes
Apr 16, 2019
|
Landing this so it will make the 0.0.15 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some JS that checks whether ES6 classes are supported (I think it's a pre-req for latest dart2js, and IE doesn't support that), and redirects to a really bare-bones "unsupported page".
Also tweaked the message shown in Edge since it categorises Edge as IE and the message is a bit confusing. It's now just called "an supported browser".
Fixes #66.