Add ServiceExtensionManager to DevTools. #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
reviewed
Dec 8, 2018
jacob314
reviewed
Dec 8, 2018
jacob314
reviewed
Dec 8, 2018
jacob314
reviewed
Dec 8, 2018
jacob314
reviewed
Dec 8, 2018
jacob314
reviewed
Dec 8, 2018
jacob314
reviewed
Dec 8, 2018
jacob314
reviewed
Dec 8, 2018
jacob314
reviewed
Dec 8, 2018
jacob314
reviewed
Dec 8, 2018
jacob314
reviewed
Dec 8, 2018
jacob314
reviewed
Dec 8, 2018
jacob314
reviewed
Dec 8, 2018
jacob314
reviewed
Dec 8, 2018
jacob314
reviewed
Dec 8, 2018
There was a problem hiding this comment.
Looks like it is on the right track. Can you add some tests? The DevTools project is setup to b e reasonable to write actual tests. The test should use a real VMService connected to a flutter app so we can verify the service extension reporting actual works as expected. It is fine for the tests to feel a bit more like integration tests than unittests. You will have to be a little bit careful dealing with testing the async behavior in the tests. Let me know if something doesn't seem like it is working.
jacob314
reviewed
Dec 10, 2018
jacob314
reviewed
Dec 10, 2018
…s into service_extensions
jacob314
reviewed
Dec 10, 2018
jacob314
approved these changes
Dec 11, 2018
jacob314
reviewed
Dec 11, 2018
jacob314
approved these changes
Dec 11, 2018
jacob314
approved these changes
Dec 14, 2018
|
Will add tests in follow up CL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds and restores service extensions from service.dart.
Follow up CLs: