Disable debug buttons in profile mode. #53
Conversation
|
|
| final Isolate isolate = await serviceInfo.service | ||
| .getIsolate(serviceInfo.isolateManager.selectedIsolate.id); | ||
|
|
||
| bool isProfileMode; |
There was a problem hiding this comment.
We should create a FlutterApp object that tracks whether the app is debug mode or not.
| @@ -46,9 +46,29 @@ class TimelineScreen extends Screen { | |||
| PButton resumeButton; | |||
|
|
|||
| @override | |||
| void createContent(Framework framework, CoreElement mainDiv) { | |||
| void createContent(Framework framework, CoreElement mainDiv) async { | |||
There was a problem hiding this comment.
I would be a little concerned about making this method Async. I would expect a reasonable contract is that this method is not async.
| ); | ||
| isProfileMode = !(evaluate is InstanceRef); | ||
| } catch (e) { | ||
| isProfileMode = true; |
There was a problem hiding this comment.
What exception is thrown? Instead of catching all exceptions verify we got the expected one.
| return new PButton(text) | ||
| ..small() | ||
| ..disabled = shouldDisableForProfileMode && isProfileMode | ||
| ..tooltip = isProfileMode ? 'Unavailable on a profile build.' : ''; |
There was a problem hiding this comment.
better is to create the UI right away with the button disabled and then enable it async when we verify the app is debug mode.
| } | ||
|
|
||
| final PButton trackWidgetBuildsButton = createButton('Track widget builds', true); | ||
| final PButton perfOverlayButton = createButton('Performance overlay', false); |
There was a problem hiding this comment.
these should be turned on and off by similar logic to VMServiceManager in the Java app instead of triggering based on whether we are in debug or profile mode. That is more robust as potentially flutter will support some or all of these options in profile mode.
|
Is this PR still relevant or has it been superseded by following PRs? |
|
PR is obsolete now. Closing. |
Also added a null check to prevent an exception.