Fix the broken build #5076
Merged
Fix the broken build #5076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
reviewed
Jan 20, 2023
| @@ -134,7 +134,12 @@ void testWidgetsWithContext( | |||
| } finally { | |||
| // restore previous global values | |||
| for (Type type in oldValues.keys) { | |||
| setGlobal(type, oldValues[type]); | |||
| final oldGlobal = oldValues[type]; | |||
| if (oldGlobal != null) { | |||
There was a problem hiding this comment.
nit: using oldValues.containsKey would be safer in case it ever matters whether the oldValue was null rather than ommitted.
There was a problem hiding this comment.
oldValues[type] will be explicitly set to null above on line 128, so oldValues will actually contain the key here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE_NOTE_EXCEPTION=[not user facing]