Handle edge cases for eval and pass needed parameters to HeapObjectGraph. #5059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonyi
approved these changes
Jan 18, 2023
| return instances.instances!.first as InstanceRef; | ||
| final result = instances.instances!.first; | ||
|
|
||
| if (result is InstanceRef) return result; |
Contributor
There was a problem hiding this comment.
In what scenario would this not be an InstanceRef? If it's only an error case, consider throwing an exception rather than having a nullable return type.
Contributor
Author
There was a problem hiding this comment.
Sometimes it is ClassRef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE_NOTE_EXCEPTION=[changes under the flag]