Add color coding for class types. #5030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonyi
reviewed
Jan 13, 2023
packages/devtools_app/lib/src/screens/memory/shared/heap/model.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/panes/diff/controller/diff_pane_controller.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/panes/diff/controller/diff_pane_controller.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/panes/diff/controller/diff_pane_controller.dart
Outdated
Show resolved
Hide resolved
| label: 'D', | ||
| alias: '\$dependency', | ||
| aliasDescription: 'dependencies', | ||
| classTooltip: 'dependency', |
There was a problem hiding this comment.
Nit: try to be consistent with capitalization
There was a problem hiding this comment.
only names (Dart, Flutter) and abbreviations (SDK) are capitalized
added comments
| classTooltip: 'Dart runtime class', | ||
| ), | ||
| sdk( | ||
| color: Color.fromARGB(255, 122, 188, 124), |
There was a problem hiding this comment.
Are these standard colors? Can they be made into constants and placed with our other colors?
There was a problem hiding this comment.
I plan to do it outside of this PR.
@malloc-error plans to work on color scheme for DevTools
There is issue to handle this: #5050
packages/devtools_app/lib/src/screens/memory/shared/primitives/class_name.dart
Show resolved
Hide resolved
| return ClassType.dependency; | ||
| } | ||
|
|
||
| bool get isCreatedByGoolge => isPackageless || isDartOrFlutter; |
packages/devtools_app/lib/src/screens/memory/shared/shared_memory_widgets.dart
Outdated
Show resolved
Hide resolved
bkonyi
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-01-12.at.5.30.17.PM.mov