Preliminary support for record types when vm_service <10.0.0

[elliette]

From what I can tell, we don't yet have access to the field names for records when vm_service is <10.0.0. This adds preliminary support for records by simply displaying the values without names.

Inspecting the following shows:

var record = (1, a: "Hello there", 3, b: 4, true);

RELEASE_NOTE_EXCEPTION='Record types not fully supported yet, will update release notes once they are'

[bkonyi]

Good timing! vm_service 10.0.0 was just published yesterday 🥳

[bkonyi]

LGTM for now, since I think it'll take Derek some time to roll vm_service through the DevTools deps.

[kenzieschmoll]

Is the record unordered?
var record = (1, a: "Hello there", 3, b: 4, true); doesn't appear to match the order in your screenshot

[elliette]

Is the record unordered? var record = (1, a: "Hello there", 3, b: 4, true); doesn't appear to match the order in your screenshot

I don't think vm_service (at version <10.0.0) is providing order information. @bkonyi correct me if I'm wrong. We are currently just displaying what we get back from the vm_service, in the order that we get it. In this case, vm_service returns:

[

// int 1
[BoundField decl: null, value: [InstanceRef id: objects/int-1, kind: Int, identityHashCode: 0, classRef: [ClassRef id: classes/59, name: _Smi, library: [LibraryRef id: libraries/@0150898, name: dart.core, uri: dart:core]]]], 

// int 3
[BoundField decl: null, value: [InstanceRef id: objects/int-3, kind: Int, identityHashCode: 0, classRef: [ClassRef id: classes/59, name: _Smi, library: [LibraryRef id: libraries/@0150898, name: dart.core, uri: dart:core]]]], 

// bool true
[BoundField decl: null, value: [InstanceRef id: objects/bool-true, kind: Bool, identityHashCode: 0, classRef: [ClassRef id: classes/62, name: bool, library: [LibraryRef id: libraries/@0150898, name: dart.core, uri: dart:core]]]],

// String "hello there"
[BoundField decl: null, value: [InstanceRef id: objects/1419, kind: String, identityHashCode: 0, classRef: [ClassRef id: classes/93, name: _OneByteString, library: [LibraryRef id: libraries/@0150898, name: dart.core, uri: dart:core]]]], 

// int 4
[BoundField decl: null, value: [InstanceRef id: objects/int-4, kind: Int, identityHashCode: 0, classRef: [ClassRef id: classes/59, name: _Smi, library: [LibraryRef id: libraries/@0150898, name: dart.core, uri: dart:core]]]]

]

[elliette]

Follow up on ordering (from @derekxu16):

With vm_service < 10.0.0 clients can't get the field names, so there's no way to determine the order. With the field names you can tell which are positional, because the names will be ints instead of Strings. Under the hood, the service returns all the positional fields in order first, and then all the named fields.