Skip to content

Make serviceManager.isolateManager source of truth for current isolate. #5004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 4, 2023

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Jan 4, 2023

RELEASE_NOTE_EXCEPTION=[refactoring]

@polina-c polina-c marked this pull request as ready for review January 4, 2023 22:24
@polina-c polina-c requested review from elliette and a team as code owners January 4, 2023 22:24
@polina-c polina-c requested review from kenzieschmoll and removed request for a team January 4, 2023 22:24
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a couple comments

Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@polina-c polina-c merged commit 3ab6c8b into flutter:master Jan 4, 2023
@polina-c polina-c deleted the refactor1 branch January 4, 2023 23:10
@CoderDake CoderDake mentioned this pull request Jan 24, 2023
7 tasks
@DartDevtoolWorkflowBot DartDevtoolWorkflowBot mentioned this pull request Jan 24, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants