Show menu for snapshot instances. #5003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonyi
reviewed
Jan 3, 2023
packages/devtools_app/lib/src/screens/memory/panes/diff/widgets/classes_table_single.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/shared/primitives/instance_set_view.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/shared/primitives/instance_set_view.dart
Outdated
Show resolved
Hide resolved
| SubmenuButton( | ||
| menuChildren: <Widget>[ | ||
| MenuItemButton( | ||
| onPressed: () => print('get fields'), |
There was a problem hiding this comment.
Is there any way we can make this constant? I assume this closure is what's preventing this entire List from being constant.
There was a problem hiding this comment.
the menu items are going to have real functional handlers, so no chances it will stay constant
| } | ||
| } | ||
|
|
||
| List<Widget> _menu() => [ |
There was a problem hiding this comment.
Nit: if we're not doing any work here, we should probably just make this a property (ideally const).
There was a problem hiding this comment.
The menu will get real actions in future PRs and this method will have parameters.
packages/devtools_app/lib/src/screens/memory/shared/primitives/instance_set_view.dart
Outdated
Show resolved
Hide resolved
bkonyi
approved these changes
Jan 3, 2023
packages/devtools_app/lib/src/screens/memory/shared/primitives/instance_set_view.dart
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE_NOTE_EXCEPTION=[under the flag]
Design
Screen.Recording.2023-01-03.at.11.13.53.AM.mov