Skip to content

Create folder for console. #4977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Create folder for console. #4977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/devtools_app/lib/devtools_app.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export 'src/shared/charts/treemap.dart';
export 'src/shared/common_widgets.dart';
export 'src/shared/config_specific/ide_theme/ide_theme.dart';
export 'src/shared/connected_app.dart';
export 'src/shared/console_service.dart';
export 'src/shared/console/console_service.dart';
export 'src/shared/error_badge_manager.dart';
export 'src/shared/globals.dart';
export 'src/shared/http/http_request_data.dart';
Expand Down
4 changes: 2 additions & 2 deletions packages/devtools_app/lib/src/screens/debugger/console.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import 'package:flutter/material.dart';
import 'package:provider/provider.dart';

import '../../shared/common_widgets.dart';
import '../../shared/console.dart';
import '../../shared/console_service.dart';
import '../../shared/console/console.dart';
import '../../shared/console/console_service.dart';
import '../../shared/globals.dart';
import '../../shared/theme.dart';
import 'debugger_controller.dart';
Expand Down
4 changes: 2 additions & 2 deletions packages/devtools_app/lib/src/screens/inspector/layout_explorer/ui/free_space.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ class FreeSpaceVisualizerWidget extends StatelessWidget {
final heightDescription =
'h=${toStringAsFixed(renderProperties.realHeight)}';
final widthDescription = 'w=${toStringAsFixed(renderProperties.realWidth)}';
final showWidth = renderProperties.realWidth !=
(renderProperties.layoutProperties?.width);
final showWidth =
renderProperties.realWidth != renderProperties.layoutProperties?.width;
final widthWidget = Column(
mainAxisAlignment: MainAxisAlignment.center,
children: [
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_app/lib/src/screens/logging/_log_details.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import 'dart:async';
import 'package:flutter/material.dart';

import '../../shared/common_widgets.dart';
import '../../shared/console.dart';
import '../../shared/console/console.dart';
import '../../shared/theme.dart';
import 'logging_controller.dart';

Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_app/lib/src/service/service_manager.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import '../screens/performance/timeline_streams.dart';
import '../shared/analytics/analytics.dart' as ga;
import '../shared/config_specific/logger/logger.dart';
import '../shared/connected_app.dart';
import '../shared/console_service.dart';
import '../shared/console/console_service.dart';
import '../shared/error_badge_manager.dart';
import '../shared/globals.dart';
import '../shared/primitives/utils.dart';
Expand Down
4 changes: 2 additions & 2 deletions packages/devtools_app/lib/src/shared/charts/chart_trace.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ class AxisScale {
Map _exponentFraction(double range) {
if (range == 0) return {};

final exponent = (log10(range)).floor().toDouble();
final exponent = log10(range).floor().toDouble();
final fraction = range / pow(10, exponent);

return {'exponent': exponent, 'fraction': fraction};
Expand All @@ -374,7 +374,7 @@ class AxisScale {
double fraction; // fractional part of range
late double niceFraction; // nice, rounded fraction

exponent = (log10(range)).floor().toDouble();
exponent = log10(range).floor().toDouble();
fraction = range / pow(10, exponent);

if (round) {
Expand Down
14 changes: 7 additions & 7 deletions .../devtools_app/lib/src/shared/console.dart → ...s_app/lib/src/shared/console/console.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ import 'dart:async';
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';

import '../screens/debugger/debugger_controller.dart';
import '../screens/debugger/variables.dart';
import 'common_widgets.dart';
import '../../screens/debugger/debugger_controller.dart';
import '../../screens/debugger/variables.dart';
import '../common_widgets.dart';
import '../primitives/auto_dispose.dart';
import '../primitives/utils.dart';
import '../theme.dart';
import '../utils.dart';
import 'console_service.dart';
import 'primitives/auto_dispose.dart';
import 'primitives/utils.dart';
import 'theme.dart';
import 'utils.dart';

// TODO(devoncarew): Allow scrolling horizontally as well.

Expand Down
16 changes: 8 additions & 8 deletions ...s_app/lib/src/shared/console_service.dart → ...b/src/shared/console/console_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ import 'dart:async';
import 'package:flutter/foundation.dart';
import 'package:vm_service/vm_service.dart';

import '../screens/debugger/debugger_model.dart';
import '../screens/inspector/diagnostics_node.dart';
import '../screens/inspector/inspector_service.dart';
import '../service/vm_service_wrapper.dart';
import 'globals.dart';
import 'object_tree.dart';
import 'primitives/auto_dispose.dart';
import 'primitives/utils.dart';
import '../../screens/debugger/debugger_model.dart';
import '../../screens/inspector/diagnostics_node.dart';
import '../../screens/inspector/inspector_service.dart';
import '../../service/vm_service_wrapper.dart';
import '../globals.dart';
import '../object_tree.dart';
import '../primitives/auto_dispose.dart';
import '../primitives/utils.dart';

/// A line in the console.
///
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_app/lib/src/shared/primitives/utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ double logBase({required int x, required int base}) {
return log(x) / log(base);
}

int log2(num x) => (logBase(x: x.floor(), base: 2)).floor();
int log2(num x) => logBase(x: x.floor(), base: 2).floor();

int roundToNearestPow10(int x) =>
pow(10, logBase(x: x, base: 10).ceil()).floor();
Expand Down