Create end to end integration test for DevTools #4976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
reviewed
Dec 22, 2022
|
|
||
| // temporary, just committed this to verify that the bots will fail if this | ||
| // test case fails. | ||
| expect(true, isFalse); |
There was a problem hiding this comment.
Commenting as a reminder to remove :)
There was a problem hiding this comment.
TODO to myself before landing - make sure the test fails on the CI when the integration test fails.
elliette
reviewed
Dec 22, 2022
elliette
reviewed
Dec 22, 2022
packages/devtools_app/integration_test/test_infra/test_app_driver.dart
Outdated
Show resolved
Hide resolved
elliette
approved these changes
Dec 22, 2022
jacob314
reviewed
Dec 22, 2022
packages/devtools_app/integration_test/test_infra/_run_test.dart
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the first end to end integration test for DevTools, and enables the integration tests to run on the CI. The test app_test.dart is very simple - it launches devtools, verifies we can connect to a real flutter app, and then navigates to every screen.
RELEASE_NOTE_EXCEPTION=testing change only