Add support for displaying profiler hits for a script in CodeView
#4831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonyi
requested review from
elliette,
kenzieschmoll and
a team
as code owners
|
Friendly bump @kenzieschmoll and @elliette, still looking for a review :-) |
Comment on lines
646
to
648
| const Divider( | ||
| height: 0, | ||
| ), |
There was a problem hiding this comment.
what is the purpose of a divider of height 0? does this actually add a border?
There was a problem hiding this comment.
height: 0 effectively removes the padding from around the divider. The divider is still rendered, just much closer to the widget above.
There was a problem hiding this comment.
Can you use OutlineDecoration.onlyBottom instead?
There was a problem hiding this comment.
It's not visually identical to a Divider, so we'd have two different line styles for the header horizontal divider and the vertical divider separating the two columns.
| try { | ||
| final report = await serviceManager.service!.getSourceReport( | ||
| isolateRef.id!, | ||
| const [SourceReportKind.kCoverage], | ||
| // TODO(bkonyi): make _Profile a public report type. |
There was a problem hiding this comment.
is there a issue filed for this in the SDK?
packages/devtools_app/lib/src/screens/vm_developer/vm_service_private_extensions.dart
Outdated
Show resolved
Hide resolved
bkonyi
force-pushed
the
codeview_profiler
branch
from
436a817 to
b134916
Compare
bkonyi
force-pushed
the
codeview_profiler
branch
from
93b1f8a to
f4910f3
Compare
kenzieschmoll
approved these changes
Dec 7, 2022
CoderDake
pushed a commit
that referenced
this pull request
Dec 9, 2022
64 tasks
bkonyi
added a commit
to bkonyi/devtools
that referenced
this pull request
Jan 10, 2023
bkonyi
added a commit
that referenced
this pull request
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
Fixes #4750