ctor ordering; fixed height for charts #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanTup
approved these changes
Oct 5, 2018
| @@ -69,4 +76,8 @@ abstract class LineChart<T> { | |||
| bool get isMounted { | |||
| return chartElement.element.parent != null; | |||
| } | |||
|
|
|||
| void dispose() { | |||
There was a problem hiding this comment.
I don't think this is being called, but I presume that's because we currently never actually destroy this (only move it out/in the DOM when changing pages)?
There was a problem hiding this comment.
Yeah, it's not called, but having it makes it slightly more clear that the object needs cleanup.
I'll add an issue for onMounted() and onUnmounted() lifecycle events (as useful, but not an immediate concern).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few different changes in here:
@DanTup