Convert broadcast stream to single-subscriber for buffering #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pausing/unpausing the websocket stream, messages are dropped. This creates a new stream that listens to the websocket stream and just relays messages (but messages will be buffered in the StreamController). Fixes #34.
devoncarew
approved these changes
Oct 3, 2018
lib/service.dart
Outdated
| @@ -196,3 +196,16 @@ class IsolateManager { | |||
| return isolates.isEmpty ? null : isolates.first; | |||
| } | |||
| } | |||
|
|
|||
| /// Wraps a broadcast stream as a single-subscription stream to workaround | |||
| /// events being dropped for DOM/WebSocker broadcast streams when paused | |||
lib/service.dart
Outdated
| /// events being dropped for DOM/WebSocker broadcast streams when paused | ||
| /// (such as in an asyncMap). | ||
| /// https://github.com/dart-lang/sdk/issues/34656 | ||
| Stream<T> wrapStream<T>(Stream<T> stream) { |
There was a problem hiding this comment.
convertBroadcastToSingleSubscriber() (or similar)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pausing/unpausing the websocket stream, messages are dropped. This creates a new stream that listens to the websocket stream and just relays messages (but messages will be buffered in the StreamController).
Fixes #34.