Skip to content

Relax SDK constraint to include Flutter stable (v1.0) #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

DanTup
Copy link
Contributor

@DanTup DanTup commented Feb 19, 2019

Flutter shipped with a v2.1.0-dev version, which is considered earlier-than v2.1.0. This change reduces the lower bound to allow any v2.1.0-dev builds.

(#80 (comment))

Flutter shipped with a v2.1.0-dev version, which is considered earlier-than v2.1.0. This change reduces the lower bound to allow any v2.1.0-dev builds.
@DanTup
Copy link
Contributor Author

DanTup commented Feb 19, 2019

@devoncarew Seems like the Travis status may be stuck again? As far as I can tell, it's all green:

https://travis-ci.org/flutter/devtools/builds/495572894

But I still see pending here. This seems to happen a lot to me on this repo, not sure if it's just me :-)

@devoncarew
Copy link
Member

I've seen this a few times now; I'd try kicking off the travis build again. We may also relax the restriction in terms of merging independent of the travis state.

@DanTup DanTup merged commit d71792b into flutter:master Feb 19, 2019
@DanTup DanTup deleted the relax-version-to-include-flutter branch February 19, 2019 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants