Skip to content

[devtools_app] Integrate the file_selector plugin #2506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 22, 2021
Merged

[devtools_app] Integrate the file_selector plugin #2506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
12a0b8a
Render the "Import File" button.
tugorez Jan 14, 2021
016fd27
Fix the extension.
tugorez Jan 14, 2021
744a9df
Add support for windows
tugorez Jan 14, 2021
4cb0f2e
Change _buildImportedFileDisplay format
tugorez Jan 14, 2021
b7bd935
Reorganize code
tugorez Jan 15, 2021
9ec5329
Restore pubspec format
tugorez Jan 15, 2021
d38453b
Refactor the file importer
tugorez Jan 15, 2021
3b0ba83
Add a different overflow strategy
tugorez Jan 15, 2021
e802e71
Revert formatting
tugorez Jan 15, 2021
6f1081f
Make extensions an optional argument.
tugorez Jan 22, 2021
566bad8
Fix the doc comment.
tugorez Jan 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 32 additions & 14 deletions packages/devtools_app/lib/src/app_size/file_import_container.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'dart:convert';
import 'package:flutter/material.dart';
import 'package:file_selector/file_selector.dart';

import '../common_widgets.dart';
import '../config_specific/drag_and_drop/drag_and_drop.dart';
Expand All @@ -19,6 +21,7 @@ class FileImportContainer extends StatefulWidget {
this.onAction,
this.onFileSelected,
this.onError,
this.extensions = const ['json'],
Key key,
}) : super(key: key);

Expand All @@ -35,6 +38,9 @@ class FileImportContainer extends StatefulWidget {

final void Function(String error) onError;

/// The file's extensions where we are going to get the data from.
final List<String> extensions;

@override
_FileImportContainerState createState() => _FileImportContainerState();
}
Expand Down Expand Up @@ -118,8 +124,7 @@ class _FileImportContainerState extends State<FileImportContainer> {
child: _buildImportedFileDisplay(),
),
),
// TODO(kenz): uncomment once file picker support is added
// _buildImportButton(),
_buildImportButton(),
// Horizontal spacer with flex value of 1.
const Flexible(
child: SizedBox(height: rowHeight),
Expand All @@ -131,25 +136,25 @@ class _FileImportContainerState extends State<FileImportContainer> {
Widget _buildImportedFileDisplay() {
return Text(
importedFile?.path ?? 'No File Selected',
overflow: TextOverflow.ellipsis,
style: TextStyle(
color: Theme.of(context).textTheme.headline1.color,
),
textAlign: TextAlign.left,
);
}

// TODO(kenz): uncomment once file picker support is added
// Widget _buildImportButton() {
// return Row(
// mainAxisAlignment: MainAxisAlignment.center,
// children: [
// OutlinedButton(
// onPressed: () {},
// child: const MaterialIconLabel(Icons.file_upload, 'Import File'),
// ),
// ],
// );
// }
Widget _buildImportButton() {
return Row(
mainAxisAlignment: MainAxisAlignment.center,
children: [
OutlinedButton(
onPressed: _importFile,
child: const MaterialIconLabel(Icons.file_upload, 'Import File'),
),
],
);
}

Widget _buildActionButton() {
return Column(
Expand All @@ -174,6 +179,19 @@ class _FileImportContainerState extends State<FileImportContainer> {
);
}

void _importFile() async {
final acceptedTypeGroups = [XTypeGroup(extensions: widget.extensions)];
final file = await openFile(acceptedTypeGroups: acceptedTypeGroups);
final data = jsonDecode(await file.readAsString());
final lastModifiedTime = await file.lastModified();
final devToolsJsonFile = DevToolsJsonFile(
data: data,
name: file.name,
lastModifiedTime: lastModifiedTime,
);
_handleImportedFile(devToolsJsonFile);
}

// TODO(kenz): add error handling to ensure we only allow importing supported
// files.
void _handleImportedFile(DevToolsJsonFile file) {
Expand Down
5 changes: 5 additions & 0 deletions packages/devtools_app/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ dependencies:
collection: ^1.15.0-nnbd
devtools_shared: 0.9.6+2
file: ^5.1.0
file_selector: ^0.7.0
file_selector_linux: ^0.0.1
file_selector_macos: ^0.0.1
file_selector_web: ^0.7.0
file_selector_windows: ^0.0.1
flutter:
sdk: flutter
flutter_web_plugins:
Expand Down