Skip to content

Commit 628b842

Browse files
DanTupDanTup
authored
Minor tidy up extracted from auto-reconnect change (#9589)
Some minor changes extracted from #9587, since that review got quite big and I want to simplify it a bit. - Exclude nested SDK from being analyzed in VS Code - Fix path in DTD task (it was correct for inside the `packages` folder but was moved to the root without updating) - Update release notes + template to not say "general updates" in all sections (when only one of them was general)
1 parent 36af80e commit 628b842

File tree

5 files changed

+28
-25
lines changed

5 files changed

+28
-25
lines changed

‎.vscode/settings.json‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,7 @@
22
// Set current working directory to devtools_app.
33
"terminal.integrated.cwd": "packages/devtools_app",
44
"dart.showTodos": false,
5+
"dart.analysisExcludedFolders": [
6+
"tool/flutter-sdk"
7+
]
58
}

‎.vscode/tasks.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"label": "Start DTD on Port 8500",
66
"detail": "Starts a DTD instance running on port 8500",
77
"type": "shell",
8-
"command": "${workspaceFolder}/../tool/flutter-sdk/bin/cache/dart-sdk/bin/dart",
8+
"command": "${workspaceFolder}/tool/flutter-sdk/bin/cache/dart-sdk/bin/dart",
99
"args": [
1010
"tooling-daemon",
1111
"--disable-service-auth-codes",

‎packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ To learn more about DevTools, check out the
1515

1616
## General updates
1717

18-
TODO: Remove this section if there are not any general updates.
18+
TODO: Remove this section if there are not any updates.
1919

2020
## Inspector updates
2121

@@ -24,11 +24,11 @@ TODO: Remove this section if there are not any general updates.
2424

2525
## Performance updates
2626

27-
TODO: Remove this section if there are not any general updates.
27+
TODO: Remove this section if there are not any updates.
2828

2929
## CPU profiler updates
3030

31-
TODO: Remove this section if there are not any general updates.
31+
TODO: Remove this section if there are not any updates.
3232

3333
## Memory updates
3434

@@ -37,19 +37,19 @@ TODO: Remove this section if there are not any general updates.
3737

3838
## Debugger updates
3939

40-
TODO: Remove this section if there are not any general updates.
40+
TODO: Remove this section if there are not any updates.
4141

4242
## Network profiler updates
4343

44-
TODO: Remove this section if there are not any general updates.
44+
TODO: Remove this section if there are not any updates.
4545

4646
## Logging updates
4747

48-
TODO: Remove this section if there are not any general updates.
48+
TODO: Remove this section if there are not any updates.
4949

5050
## App size tool updates
5151

52-
TODO: Remove this section if there are not any general updates.
52+
TODO: Remove this section if there are not any updates.
5353

5454
## Deep links tool updates
5555

@@ -61,15 +61,15 @@ TODO: Remove this section if there are not any general updates.
6161

6262
## VS Code Sidebar updates
6363

64-
TODO: Remove this section if there are not any general updates.
64+
TODO: Remove this section if there are not any updates.
6565

6666
## DevTools Extension updates
6767

68-
TODO: Remove this section if there are not any general updates.
68+
TODO: Remove this section if there are not any updates.
6969

7070
## Advanced developer mode updates
7171

72-
TODO: Remove this section if there are not any general updates.
72+
TODO: Remove this section if there are not any updates.
7373

7474
## Full commit history
7575

‎packages/devtools_app/release_notes/helpers/release_notes_template.md‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,55 +15,55 @@ To learn more about DevTools, check out the
1515

1616
## General updates
1717

18-
TODO: Remove this section if there are not any general updates.
18+
TODO: Remove this section if there are not any updates.
1919

2020
## Inspector updates
2121

22-
TODO: Remove this section if there are not any general updates.
22+
TODO: Remove this section if there are not any updates.
2323

2424
## Performance updates
2525

26-
TODO: Remove this section if there are not any general updates.
26+
TODO: Remove this section if there are not any updates.
2727

2828
## CPU profiler updates
2929

30-
TODO: Remove this section if there are not any general updates.
30+
TODO: Remove this section if there are not any updates.
3131

3232
## Memory updates
3333

34-
TODO: Remove this section if there are not any general updates.
34+
TODO: Remove this section if there are not any updates.
3535

3636
## Debugger updates
3737

38-
TODO: Remove this section if there are not any general updates.
38+
TODO: Remove this section if there are not any updates.
3939

4040
## Network profiler updates
4141

42-
TODO: Remove this section if there are not any general updates.
42+
TODO: Remove this section if there are not any updates.
4343

4444
## Logging updates
4545

46-
TODO: Remove this section if there are not any general updates.
46+
TODO: Remove this section if there are not any updates.
4747

4848
## App size tool updates
4949

50-
TODO: Remove this section if there are not any general updates.
50+
TODO: Remove this section if there are not any updates.
5151

5252
## Deep links tool updates
5353

54-
TODO: Remove this section if there are not any general updates.
54+
TODO: Remove this section if there are not any updates.
5555

5656
## VS Code Sidebar updates
5757

58-
TODO: Remove this section if there are not any general updates.
58+
TODO: Remove this section if there are not any updates.
5959

6060
## DevTools Extension updates
6161

62-
TODO: Remove this section if there are not any general updates.
62+
TODO: Remove this section if there are not any updates.
6363

6464
## Advanced developer mode updates
6565

66-
TODO: Remove this section if there are not any general updates.
66+
TODO: Remove this section if there are not any updates.
6767

6868
## Full commit history
6969

‎tool/lib/commands/release_notes_helper.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ class _DevToolsReleaseNotes {
208208

209209
// TODO(kenz): one nice polish task could be to remove sections that are
210210
// empty (i.e. sections that have the line
211-
// "TODO: Remove this section if there are not any general updates.").
211+
// "TODO: Remove this section if there are not any updates.").
212212
final srcLines = rawLines.sublist(titleLineIndex);
213213
final imageLineIndices = <int>{};
214214
for (int i = 0; i < srcLines.length; i++) {

0 commit comments

Comments
 (0)