Skip to content

Commit 36af80e

Browse files
authored
Delete launched propertyEditorRefactors feature flag (#9579)
1 parent 8005ab7 commit 36af80e

File tree

4 files changed

+1
-16
lines changed

4 files changed

+1
-16
lines changed

packages/devtools_app/lib/src/shared/feature_flags.dart

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,6 @@ extension FeatureFlags on Never {
8585
enabled: true,
8686
);
8787

88-
/// Flag to enable refactors in the Flutter Property Editor sidebar.
89-
///
90-
/// https://github.com/flutter/devtools/issues/9214
91-
static final propertyEditorRefactors = BooleanFeatureFlag(
92-
name: 'propertyEditorRefactors',
93-
enabled: true,
94-
);
95-
9688
/// A set of all the boolean feature flags for debugging purposes.
9789
///
9890
/// When adding a new boolean flag, you are responsible for adding it to this
@@ -103,7 +95,6 @@ extension FeatureFlags on Never {
10395
devToolsExtensions,
10496
dapDebugging,
10597
inspectorV2,
106-
propertyEditorRefactors,
10798
};
10899

109100
/// A set of all the Flutter channel feature flags for debugging purposes.

packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_controller.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import '../../../shared/analytics/analytics.dart' as ga;
1111
import '../../../shared/analytics/constants.dart' as gac;
1212
import '../../../shared/editor/api_classes.dart';
1313
import '../../../shared/editor/editor_client.dart';
14-
import '../../../shared/feature_flags.dart';
1514
import '../../../shared/ui/filter.dart';
1615
import '../../../shared/utils/utils.dart';
1716
import 'property_editor_types.dart';
@@ -223,8 +222,7 @@ class PropertyEditorController extends DisposableController
223222
CodeActionResult? refactorsResult;
224223
// TODO(https://github.com/flutter/devtools/issues/8652): Enable refactors
225224
// in the Property Editor by default.
226-
if (editableArgsResult != null &&
227-
FeatureFlags.propertyEditorRefactors.isEnabled) {
225+
if (editableArgsResult != null) {
228226
// Fetch the refactors using the start of the editable arguments' range,
229227
// which corresponds to the widget constructor name. This ensures that the
230228
// refactors are always available, even when the cursor is within the

packages/devtools_app/test/shared/primitives/feature_flags_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ void main() {
2121
expect(FeatureFlags.devToolsExtensions.isEnabled, isExternalBuild);
2222
expect(FeatureFlags.dapDebugging.isEnabled, false);
2323
expect(FeatureFlags.inspectorV2.isEnabled, true);
24-
expect(FeatureFlags.propertyEditorRefactors.isEnabled, true);
2524
});
2625

2726
group('FlutterChannelFeatureFlag', () {

packages/devtools_app/test/standalone_ui/ide_shared/property_editor/property_editor_test.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import 'dart:ui';
99
import 'package:devtools_app/devtools_app.dart';
1010
import 'package:devtools_app/src/shared/analytics/constants.dart' as gac;
1111
import 'package:devtools_app/src/shared/editor/api_classes.dart';
12-
import 'package:devtools_app/src/shared/feature_flags.dart';
1312
import 'package:devtools_app/src/standalone_ui/ide_shared/property_editor/property_editor_controller.dart';
1413
import 'package:devtools_app/src/standalone_ui/ide_shared/property_editor/property_editor_refactors.dart';
1514
import 'package:devtools_app/src/standalone_ui/ide_shared/property_editor/property_editor_types.dart';
@@ -927,8 +926,6 @@ void main() {
927926
);
928927

929928
setUp(() {
930-
FeatureFlags.propertyEditorRefactors.setEnabledForTests(true);
931-
932929
refactorCount = 0;
933930
when(
934931
// ignore: discarded_futures, for mocking purposes.

0 commit comments

Comments
 (0)