Skip to content

Should not return 405 when config is off. #4900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtmcdole merged 2 commits into from
Dec 18, 2025
Merged

Should not return 405 when config is off. #4900

jtmcdole merged 2 commits into from
Dec 18, 2025

Conversation

@jtmcdole
Copy link
Member

@jtmcdole jtmcdole commented Dec 18, 2025

No description provided.

@jtmcdole jtmcdole requested a review from ievdokdm December 18, 2025 23:21
@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App. label Dec 18, 2025
@jtmcdole jtmcdole mentioned this pull request Dec 18, 2025
Closed
@jtmcdole jtmcdole removed the autosubmit Merge PR when tree becomes green via auto submit App. label Dec 18, 2025
@jtmcdole
Copy link
Member Author

jtmcdole commented Dec 18, 2025

will add some more testing that wasn't caught with mocks :(

@jtmcdole
Copy link
Member Author

jtmcdole commented Dec 18, 2025

more tests.... having Firebase data model and having an RPC model leads to missing this :(

ievdokdm
ievdokdm approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@ievdokdm ievdokdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtmcdole jtmcdole closed this Dec 18, 2025
@jtmcdole jtmcdole reopened this Dec 18, 2025
@fluttergithubbot
Copy link

fluttergithubbot commented Dec 18, 2025

An existing Git SHA, 161a3901d5b4184efef3b399a6209b4da40fa7fd, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

@jtmcdole jtmcdole merged commit 7fde274 into flutter:main Dec 18, 2025
29 checks passed
ievdokdm pushed a commit to ievdokdm/cocoon that referenced this pull request Dec 20, 2025
@jtmcdole @ievdokdm
Should not return 405 when config is off. (flutter#4900)
eab51e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ievdokdm ievdokdm ievdokdm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtmcdole @fluttergithubbot @ievdokdm