Skip to content

chore: turn on waitOnContentHash flag #4706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025
Merged

Conversation

jtmcdole
Copy link
Member

Enable waitOnContentHash for the merge queue.

If something goes wrong; revert this PR and wait ~2 minutes.

@jtmcdole jtmcdole requested a review from matanlurey May 19, 2025 19:57
@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App. label May 19, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App. label May 19, 2025
Copy link
Contributor

auto-submit bot commented May 19, 2025

autosubmit label was removed for flutter/cocoon/4706, because - The status or check suite test-app-dart has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jtmcdole
Copy link
Member Author

Blocked waiting for #4707

@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App. label May 19, 2025
@auto-submit auto-submit bot merged commit 14278d8 into main May 19, 2025
17 checks passed
@jtmcdole
Copy link
Member Author

reason for revert: I didn't push the new cocoon out tha towuld parse this flag... whoops

@jtmcdole jtmcdole added the revert Label used to revert changes in a closed and merged pull request. label May 19, 2025
auto-submit bot pushed a commit that referenced this pull request May 19, 2025
@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label May 19, 2025
jtmcdole pushed a commit that referenced this pull request May 19, 2025
<!-- start_original_pr_link -->
Reverts: #4706
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: I didn't push the new cocoon out tha towuld parse
this flag... whoops
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jtmcdole
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {matanlurey}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Enable `waitOnContentHash` for the merge queue.

If something goes wrong; revert this PR and wait ~2 minutes.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants