Conditionally lock MQG on flutter/flutter+master only.
#4685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtmcdole
approved these changes
May 15, 2025
| final lock = await lockMergeGroupChecks(slug, pullRequest.head!.sha!); | ||
| final CheckRun? lock; | ||
| { | ||
| if (!isFusion) { |
There was a problem hiding this comment.
I prefer more positive logic:
if (isFusion && Config.defaultBranch(slug) == pullRequest.head!.ref) {
lock = await _lckMergeGroupChecks(...);
} else {
log.debug('Skipping merge queue guard: not a merge group request; $slug / $ref');
lock = null;
}
matanlurey
added
the
autosubmit
matanlurey
added
the
revert
|
A reason for requesting a revert of flutter/cocoon/4685 could |
auto-submit
bot
removed
the
revert
|
reason for revert: Breaks Flutter CI progression from engine -> framework |
matanlurey
added
the
revert
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
May 16, 2025
…4685)" (#4691) Reverts: #4685 Initiated by: matanlurey Reason for reverting: Breaks Flutter CI progression from engine -> framework Original PR Author: matanlurey Reviewed By: {jtmcdole} This change reverts the following previous change: Closes flutter/flutter#168867.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#168867.