Skip to content

Use GITHUB_ACTIONS to determine a CI run. #4684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

matanlurey
Copy link
Contributor

@matanlurey matanlurey requested a review from jtmcdole May 14, 2025 20:13
Copy link
Member

@jtmcdole jtmcdole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kahn-star-trek

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App. label May 14, 2025
@auto-submit auto-submit bot merged commit fbe2598 into flutter:main May 14, 2025
17 checks passed
@@ -50,8 +50,14 @@ class CocoonFileComparator extends LocalFileComparator {
return super.getGoldenBytes(golden);
}

static bool get _isLuciCi {
return !kIsWeb && Platform.environment.containsKey('LUCI_CONTEXT');
static bool get _isRunningOnCi {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we log that we're running on CI so.. you know... we see it?

actions are setup to run on ubuntu, so it should be the same locally or on github as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cocoon golden-file tests are not running since moving to GitHub actions
2 participants