Skip to content

Commit 68e36df

Browse files
authored
Add test exemption for embedder tests and fixtures (#2340)
Embedder API tests in the engine are implemented as C++ unit tests and test infrastructure such as embedder_test_context_metal.{h,cc} (located under the shell/platform/embedder/tests directory), which execute and test Dart functions (and associated test assets) stored in the shell/platform/embedder/fixtures directory. Uncovered while sending flutter/engine#38133. Issue: flutter/flutter#116381
1 parent 2833a80 commit 68e36df

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

app_dart/lib/src/request_handlers/github/webhook_subscription.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,9 @@ class GithubWebhookSubscription extends SubscriptionHandler {
313313
filename.contains('.github/') ||
314314
filename.endsWith('.md') ||
315315
// Exempt paths.
316-
filename.startsWith('dev/devicelab/lib/versions/gallery.dart');
316+
filename.startsWith('dev/devicelab/lib/versions/gallery.dart') ||
317+
filename.startsWith('shell/platform/embedder/tests') ||
318+
filename.startsWith('shell/platform/embedder/fixtures');
317319
}
318320

319321
/// Returns the set of labels applicable to a file in the framework repo.

app_dart/test/request_handlers/github/webhook_subscription_test.dart

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -889,9 +889,11 @@ void main() {
889889
final RepositorySlug slug = RepositorySlug('flutter', 'flutter');
890890

891891
when(pullRequestsService.listFiles(slug, issueNumber)).thenAnswer(
892-
(_) => Stream<PullRequestFile>.value(
892+
(_) => Stream<PullRequestFile>.fromIterable(<PullRequestFile>[
893893
PullRequestFile()..filename = 'dev/devicelab/lib/versions/gallery.dart',
894-
),
894+
PullRequestFile()..filename = 'shell/platform/embedder/tests/embedder_test_context.cc',
895+
PullRequestFile()..filename = 'shell/platform/embedder/fixtures/main.dart',
896+
]),
895897
);
896898

897899
when(issuesService.listCommentsByIssue(slug, issueNumber)).thenAnswer(

0 commit comments

Comments
 (0)