Add test exemption for embedder tests and fixtures #2340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Embedder API tests in the engine are implemented as C++ unit tests and
test infrastructure such as embedder_test_context_metal.{h,cc} (located
under the shell/platform/embedder/tests directory), which execute and
test Dart functions (and associated test assets) stored in the
shell/platform/embedder/fixtures directory.
Uncovered while sending flutter/engine#38133.
Issue: flutter/flutter#116381
chinmaygarde
approved these changes
Dec 8, 2022
This was referenced Dec 8, 2022
CaseyHillers
approved these changes
Dec 8, 2022
cbracken
added
the
autosubmit
cbracken
added a commit
to flutter/engine
that referenced
this pull request
Dec 8, 2022
While I've sent a patch to mark the shell/platform/embedder/tests and fixtures directories as test exempt (since they are tests), by convention, tests should end in _unittests.* for C++ tests, and _test.* for Dart tests. This renames for consistency with other tests such as embedder_a11y_unittests.cc. Uncovered by #38133 Related: flutter/cocoon#2340 Issue: flutter/flutter#116381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embedder API tests in the engine are implemented as C++ unit tests and test infrastructure such as embedder_test_context_metal.{h,cc} (located under the shell/platform/embedder/tests directory), which execute and test Dart functions (and associated test assets) stored in the shell/platform/embedder/fixtures directory.
Uncovered while sending flutter/engine#38133.
Issue: flutter/flutter#116381
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.