Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Reland "[Darwin] Disable NSAsserts in release builds. #860" #919

Closed
wants to merge 1 commit into from

Conversation

hellohuanlin
Copy link

@hellohuanlin hellohuanlin commented Nov 15, 2024

Need to make sure this doesn't fail the CI for engine repo.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@hellohuanlin
Copy link
Author

Need to make sure this doesn't fail the CI for engine repo.

@hellohuanlin
Copy link
Author

This is still pending the other build to pass. Let me convert it to draft

@hellohuanlin hellohuanlin marked this pull request as draft November 25, 2024 18:49
@goderbauer
Copy link
Member

(triage): I am going to close this one since after the mono-repo merge the buildroot is now part of the regular flutter/flutter repository. If this change is still needed, please open a new PR on flutter/flutter. Thank you.

@goderbauer goderbauer closed this Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants