This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Remove old FIDL tables.c file from build #821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that flutter#798 added the new tables.c file, and https://fxrev.dev/946309 moved the content from the old file to the new file, we can stop generating the old file (i.e. stop passing --tables to fidlc). See https://fxbug.dev/42115242 for context.
jrwang
approved these changes
Jan 29, 2024
|
I manually tested that this works: $ENGINE_DIR/flutter/tools/gn --fuchsia --no-lto --fuchsia-cpu=arm64 --runtime-mode=debug --goma --unoptimized
ninja -C $ENGINE_DIR/out/fuchsia_debug_unopt_arm64 flutter/shell/platform/fuchsiaI also confirmed GN errors and linker errors when I changed the diff to be incorrect, so I know I'm building the right thing. |
mk12
added a commit
to mk12/engine
that referenced
this pull request
Jan 30, 2024
To pick up flutter/buildroot#821
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Jan 30, 2024
To pick up flutter/buildroot#821, which completed the migration to the fidlgen_cpp tables.c file. This will unblock landing https://fxrev.dev/953990, which removes the fidlc `--tables` flag. This work is tracked in https://fxbug.dev/42115242.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #798 added the new tables.c file, and https://fxrev.dev/946309 moved the content from the old file to the new file, we can stop generating the old file (i.e. stop passing --tables to fidlc).
See https://fxbug.dev/42115242 for context.