Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Conversation

@harryterkelsen
Copy link
Contributor

Brotli is needed to support .woff2 and .woff fonts on the web. woff2 is the default format served by Google Fonts.

See also flutter/engine#41282

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chinmaygarde
Copy link
Member

Can we land this?

Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this has to be added in the buildroot repo? Can we put it in the engine repo like this?

@chinmaygarde
Copy link
Member

No. That seems like a better place for this in fact. It is being DEPSed to the flutter/third_party though right?

@chinmaygarde
Copy link
Member

@hterkelsen: Are you planning on taking this to flutter/third_party or leaving it here?

@chinmaygarde
Copy link
Member

Closing this as stale.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants