This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Embed ICU data inside libflutter.so on Android #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
reviewed
Jan 26, 2019
| } else if (is_android) { | ||
| # Only export JNI_OnLoad symbol. | ||
| _shared_library_configs += | ||
| [ "//build/config/android:hide_all_but_jni_onload" ] |
There was a problem hiding this comment.
Should we delete this target and the file it references as well from the buildroot?
There was a problem hiding this comment.
I'm ok with keeping it - it's part of the current Chromium buildroot
chinmaygarde
approved these changes
Jan 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See flutter/engine#7588