Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 2, 2022

Add a HTTP Live Streaming (HLS) .m3u8 file to test in the video_player plugin flutter/flutter#97206

Created from the existing bee.mp4 video:

$ ffmpeg -i bee.mp4 -g 60 -hls_time 2 -hls_list_size 0 -hls_segment_size 500000 bee.m3u8

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@IlyaMax
Copy link

IlyaMax commented Feb 2, 2022

It would be useful to add longer video to example to test issues with video_player in bad internet condition. At least 2 minutes if it possible so buffer couldn't fill up. I'm going to contribute with this in flutter/plugins#4693

@jmagman
Copy link
Member Author

jmagman commented Feb 2, 2022

It would be useful to add longer video to example to test issues with video_player in bad internet condition. At least 2 minutes if it possible so buffer couldn't fill up. I'm going to contribute with this in flutter/plugins#4693

Is there some reason that needs to be HLS and not mp4 or other video format?

@stuartmorgan-g
Copy link

We recently switched webview_flutter tests from external URLs to an in-test web server. That's the way we should be moving with video_player as well (it just hasn't been done yet) so more complex use cases like really slow loading should be done via a test server rather than adding more complex assets here.

Copy link

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants