Skip to content

[video_player_avplay] Fix subtitle crash issue for DASH stream.#963

Open
gin7773 wants to merge 5 commits intoflutter-tizen:masterfrom
gin7773:fix_crash_issue_0213
Open

[video_player_avplay] Fix subtitle crash issue for DASH stream.#963
gin7773 wants to merge 5 commits intoflutter-tizen:masterfrom
gin7773:fix_crash_issue_0213

Conversation

@gin7773
Copy link
Contributor

@gin7773 gin7773 commented Feb 26, 2026

Main changes:

  • Update plusplayer
    1. [DASH] Fix subtitle crash issue.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the "video_player_avplay" package to version 0.8.2, aiming to fix a subtitle crash issue for DASH streams. However, a high-severity vulnerability has been identified in the picture-based subtitle handling logic. The "channels" and "stride" for PNG encoding are calculated from untrusted external input without proper validation, which can lead to out-of-bounds memory access and potential information disclosure. Additionally, there's an issue with incorrect data types being passed to the PNG conversion function, which could cause further problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants