[video_player_avplay] Fix subtitle crash issue for DASH stream.#963
Open
gin7773 wants to merge 5 commits intoflutter-tizen:masterfrom
Open
[video_player_avplay] Fix subtitle crash issue for DASH stream.#963gin7773 wants to merge 5 commits intoflutter-tizen:masterfrom
gin7773 wants to merge 5 commits intoflutter-tizen:masterfrom
Conversation
xiaowei-guan
approved these changes
Feb 26, 2026
There was a problem hiding this comment.
Code Review
This pull request updates the "video_player_avplay" package to version 0.8.2, aiming to fix a subtitle crash issue for DASH streams. However, a high-severity vulnerability has been identified in the picture-based subtitle handling logic. The "channels" and "stride" for PNG encoding are calculated from untrusted external input without proper validation, which can lead to out-of-bounds memory access and potential information disclosure. Additionally, there's an issue with incorrect data types being passed to the PNG conversion function, which could cause further problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes: