[video_player_videohole] Add video_player_videohole package #468

hyue7 · 2022-10-19T08:30:53Z

”video_player_videohole“ is a new video player plugin ,used to play videos of DRM (playready & widevine).It's based on MM player and only supports on Tizen TV devices

huayongxu

lgtm

elishateng

LGTM

wb0716

Good for me

AdunFang

It is OK.

zhouleonlei

lgtm

packages/video_player_videohole/example/tizen/tizen-manifest.xml

packages/video_player_videohole/tizen/src/drm_licence.cc

packages/video_player_videohole/tizen/src/drm_manager.cc

packages/video_player_videohole/tizen/src/drm_manager_service_proxy.cc

packages/video_player_videohole/tizen/src/video_player.cc

packages/video_player_videohole/pigeons/messages.dart

packages/video_player_videohole/tizen/src/video_player.h

packages/video_player_videohole/tizen/src/drm_manager_service_proxy.cc

packages/video_player_videohole/tizen/src/drm_manager.cc

packages/video_player_videohole/tizen/src/drm_manager.h

packages/video_player_videohole/tizen/src/drm_manager.cc

xuelian-bai · 2022-10-26T02:10:51Z

Let me explain why this is a seperated plugin:

Dart API is different with official video_player plugin, so if we integrate this plugin into video_player plugin, then video_player plugin is not cross-platform.
The supported features of this new plugin can cover that of video_player plugin, so it's no need to integrate new one into video_player plugin

@swift-kim

bbrto21 · 2022-10-26T04:47:44Z

Great, I've confirmed that the example is working well generally with platform certification on my TV device.
but I got some error. this happened when I played a video while moving between tabs on example.

Another exception was thrown: setState() called after dispose(): _DrmRemoteVideoState#45a3b(lifecycle state: defunct,

packages/video_player_videohole/tizen/src/drm_manager.h

packages/video_player_videohole/tizen/src/drm_licence.cc

packages/video_player_videohole/tizen/src/drm_licence.h

packages/video_player_videohole/tizen/src/messages.cc

packages/video_player_videohole/tizen/src/video_player.cc

packages/video_player_videohole/tizen/src/video_player_tizen_plugin.cc

packages/video_player_videohole/tizen/src/drm_manager.cc

packages/video_player_videohole/tizen/src/messages.cc

packages/video_player_videohole/tizen/src/video_player.cc

packages/video_player_videohole/tizen/src/messages.h

packages/video_player_videohole/tizen/src/video_player.cc

packages/video_player_videohole/tizen/src/messages.h

bbrto21 · 2022-10-27T02:31:50Z

Please refer to the implementation of other plugins and the developer guide.
and carefully follow the naming convention for each language .
Ex) Typically, we do not use camel case for variable names in the C++ code.

swift-kim · 2022-11-21T02:48:45Z

Please take a look at this error report.

flutter-tizen/flutter-tizen#217 (comment)

packages/video_player_videohole/tizen/src/video_player.cc

swift-kim · 2022-12-05T06:48:50Z

https://github.com/flutter-tizen/flutter-tizen/wiki/New-plugin-submission-guideline

Please make sure all the requirements are satisfied. Especially pay attention to the coding style (do not use abbreviations and etc.).

swift-kim · 2023-03-23T07:38:15Z

Is the video_player_videohole dev branch unused? You may reopen this PR by force-pushing recent changes to the branch, so that I can push some changes directly to the branch during review.

hyue7 · 2023-03-23T08:21:07Z

Is the video_player_videohole dev branch unused? You may reopen this PR by force-pushing recent changes to the branch, so that I can push some changes directly to the branch during review.

@swift-kim You can directly review in this PR，there will be conflicts if push this to video_player_videohole branch.

swift-kim · 2023-03-23T08:39:15Z

What conflicts?

packages/video_player_videohole/tizen/src/messages.h

swift-kim · 2023-03-24T05:06:08Z

Reopened: #550

hyue7 added 2 commits October 18, 2022 18:45

version 1.0.0

345399f

Code format

81c8ebc

huayongxu approved these changes Oct 19, 2022

View reviewed changes

elishateng approved these changes Oct 19, 2022

View reviewed changes

wb0716 approved these changes Oct 19, 2022

View reviewed changes

AdunFang approved these changes Oct 19, 2022

View reviewed changes

zhouleonlei approved these changes Oct 19, 2022

View reviewed changes

xuelian-bai reviewed Oct 19, 2022

View reviewed changes

packages/video_player_videohole/example/tizen/tizen-manifest.xml Outdated Show resolved Hide resolved

hyue7 added 2 commits October 20, 2022 09:35

Code format

0502027

remove unnecessary_import

35385e6

wanchao-xu reviewed Oct 20, 2022

View reviewed changes

swift-kim changed the title ~~[video_player_videohole]videoplayer plugin~~ [video_player_videohole] Add video_player_videohole package Oct 20, 2022

xuelian-bai reviewed Oct 20, 2022

View reviewed changes

packages/video_player_videohole/tizen/src/video_player.cc Outdated Show resolved Hide resolved

packages/video_player_videohole/tizen/src/video_player.cc Outdated Show resolved Hide resolved

modify code

60de883

xiaowei-guan self-requested a review October 20, 2022 08:48

device only supports Tizen tv

d4552fb

xuelian-bai requested review from bbrto21, haesik and swift-kim October 24, 2022 00:55

xuelian-bai mentioned this pull request Oct 24, 2022

[WIP][video_player_plusplayer]Plusplayer plugin #374

Closed

xiaowei-guan reviewed Oct 24, 2022

View reviewed changes

bbrto21 reviewed Oct 26, 2022

View reviewed changes

packages/video_player_videohole/tizen/src/drm_manager.cc Outdated Show resolved Hide resolved

packages/video_player_videohole/tizen/src/messages.cc Outdated Show resolved Hide resolved

packages/video_player_videohole/tizen/src/video_player.cc Show resolved Hide resolved

JSUYA reviewed Oct 26, 2022

View reviewed changes

packages/video_player_videohole/tizen/src/messages.h Show resolved Hide resolved

bbrto21 reviewed Oct 27, 2022

View reviewed changes

Remove the unnecessary code

1b1ada7

hyue7 force-pushed the master branch from 8202f13 to 1a729ce Compare November 25, 2022 09:57

hyue7 added 2 commits November 25, 2022 17:57

Remove pigeon path and fix return fail case issue

1a729ce

Fix get window geometry issue

6bfa457

swift-kim reviewed Nov 29, 2022

View reviewed changes

packages/video_player_videohole/tizen/src/video_player.cc Outdated Show resolved Hide resolved

packages/video_player_videohole/tizen/src/video_player.cc Outdated Show resolved Hide resolved

packages/video_player_videohole/tizen/src/video_player.cc Outdated Show resolved Hide resolved

hyue7 added 2 commits November 30, 2022 16:18

Code format

056d847

Fix return empty error message issue

d5264a8

hyue7 added 9 commits December 6, 2022 15:31

Remove unnecessary package and apply c++ style

4106044

Add license request callback

32c945c

Update callback of requesting drm license

1302979

update request drm license through ffi

e144cb3

fixed the issue about license request callback

052720e

set license request callback in example code

8d34fe8

support internal subtitles from stream

f299572

Merge remote-tracking branch 'upstream/master'

a57f343

Merge branch 'master' of https://github.com/hyue7/plugins

9555351

hyue7 force-pushed the master branch from 55d6c16 to e215d54 Compare February 9, 2023 08:29

hyue7 added 3 commits February 9, 2023 16:30

modify README

e215d54

Modify variables naming style

05268f5

Modify variables naming style

f6e9952

hyue7 force-pushed the master branch from b8ea397 to f6e9952 Compare March 23, 2023 02:53

swift-kim reviewed Mar 23, 2023

View reviewed changes

packages/video_player_videohole/tizen/src/messages.h Show resolved Hide resolved

Merge remote-tracking branch 'remotes/upstream/master'

180b311

swift-kim mentioned this pull request Mar 23, 2023

[video_player_videohole] Add video_player_videohole package #548

Closed

swift-kim closed this Mar 24, 2023

[video_player_videohole] Add video_player_videohole package #468

[video_player_videohole] Add video_player_videohole package #468

Uh oh!

Conversation

hyue7 commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

huayongxu left a comment

Choose a reason for hiding this comment

Uh oh!

elishateng left a comment

Choose a reason for hiding this comment

Uh oh!

wb0716 left a comment

Choose a reason for hiding this comment

Uh oh!

AdunFang left a comment

Choose a reason for hiding this comment

Uh oh!

zhouleonlei left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xuelian-bai commented Oct 26, 2022

Uh oh!

bbrto21 commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bbrto21 commented Oct 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

swift-kim commented Nov 21, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hyue7 commented Oct 19, 2022 •

edited

Loading

bbrto21 commented Oct 26, 2022 •

edited

Loading

bbrto21 commented Oct 27, 2022 •

edited

Loading